Coder Social home page Coder Social logo

Comments (4)

spacenick avatar spacenick commented on September 4, 2024

I have to specify that I'm using the oauth_flow.php file to test it, and everything runs fine untill there!

from tmhoauth.

spacenick avatar spacenick commented on September 4, 2024

Adding this after line 266ish makes the trick :

if (isset($_signing_params['oauth_verifier'])) {
$this->auth_params['oauth_verifier'] = $_signing_params['oauth_verifier'];
unset($_signing_params['oauth_verifier']);
}

Just wondering why it wasn't doing it by default since sending oauth_verifier in the Authorization header is in the OAuth 1.0a last spec, maybe I did something wrong

from tmhoauth.

themattharris avatar themattharris commented on September 4, 2024

Thanks, the Twitter API is fairly lenient on where the parameters are located (header or GET/POST params) but it's still better to be correct. I'll add the code to ensure oauth_verifier (when set) is in the authorization header and push a new version up.

I have a few other hardening changes that i'm adding at the moment but I expect to push the new version within the week. When I do i'll close the issue.

from tmhoauth.

themattharris avatar themattharris commented on September 4, 2024

Just pushed that change with v0.60 so i'm closing this issue. Thanks again. (Props are in the readme ;) )

from tmhoauth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.