Coder Social home page Coder Social logo

Comments (3)

gary02 avatar gary02 commented on May 24, 2024 1

https://github.com/thematters/matters-html-formatter/blob/9242e4c4196973d0c5d472ab6bc9767afb8966e2/src/makeHtmlBundle/getAsset.ts#L35-L47

The 2 test errors above are caused by fetch function which fail to fetch files and throw error in my env.

I think fetch should be mocked and tests the cases that fetch throws errors or not

from ipns-site-generator.

guoliu avatar guoliu commented on May 24, 2024 1

https://github.com/thematters/matters-html-formatter/blob/9242e4c4196973d0c5d472ab6bc9767afb8966e2/src/makeHtmlBundle/getAsset.ts#L35-L47

The 2 test errors above are caused by fetch function which fail to fetch files and throw error in my env.

I think fetch should be mocked and tests the cases that fetch throws errors or not

Great catch! Yes fetch should definitely be mocked to be independent of the local network.

from ipns-site-generator.

gary02 avatar gary02 commented on May 24, 2024

setTimeout to big number can be a workaround. But the tests still failed and take too much time:

2022-08-16-131217_1867x826_scrot

from ipns-site-generator.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.