Can't get date on -modifié.jpg files about googlephotostakeouthelper

[palijn]

Hi! I looked into this again, i still have no idea - it works perfect in the tests... - do you still have this problem

I have no idea honestly. I got my Takeouts to leave GPhotos forever, so, now I'm basically done with them. There were not so many -modifié files, I simply moved them by hand close to the original file.

You're welcome, I like giving back help.

[TheLastGimbus]

can you show here the names of the jsons that should be found?

i have tests from them like this:

GooglePhotosTakeoutHelper/test/gpth_test.dart

Lines 43 to 45 in 959b78b

	final imgFile6 = File('IMG-20150125-WA0003-modifié.jpg');
	final imgFile6_1 = File('IMG-20150125-WA0003-modifié(1).jpg');
	final jsonFile6 = File('IMG-20150125-WA0003.jpg.json');

GooglePhotosTakeoutHelper/test/gpth_test.dart

Lines 122 to 135 in 959b78b

	expect(
	(await jsonExtractor(imgFile6, tryhard: false))?.millisecondsSinceEpoch,
	1422183600 * 1000,
	);
	expect(
	(await jsonExtractor(imgFile6_1, tryhard: false))
	?.millisecondsSinceEpoch,
	null,
	);
	expect(
	(await jsonExtractor(imgFile6_1, tryhard: true))
	?.millisecondsSinceEpoch,
	1422183600 * 1000,
	);

and they pass 👀

[palijn]

Mmh, let's have a look :

Takeout/Google Photos/Photos from 2015 % grep IMG-20150118-WA0000-modifié.jpg *.json
Takeout/Google Photos/Photos from 2015 % grep IMG-20150118-WA0000 *.json
IMG-20150118-WA0000.jpg.json: "title": "IMG-20150118-WA0000.jpg",

Takeout/Google Photos/Photos from 2015 % grep IMG-20150101-WA0001-modifié.jpg *.json
Takeout/Google Photos/Photos from 2015 % grep IMG-20150101-WA0001 *.json
IMG-20150101-WA0001.jpg.json: "title": "IMG-20150101-WA0001.jpg",

Is that good for you ?

[palijn]

If I correctly read your tests, they expect one json file per -modifié jpg.
However, the -modifié jpg do not have their own json files, the only reference to the file is to be found with the filename root in the un-modified json file.

[TheLastGimbus]

Look again - the test are expecting to find the original non-modified file json, as they should

I see you printed their jsons, but could you just show the filenames themselves? As many as you can

[palijn]

Well, the grep does show the file name before the matching contents, and I grepped every json file in the folder (*.json)…
So, there is only 1 json file that matches, such as IMG-20150118-WA0000.jpg.json or IMG-20150101-WA0001.jpg.json.

[TheLastGimbus]

Hi! I looked into this again, i still have no idea - it works perfect in the tests... - do you still have this problem

ps. again big thanks for the help you give people around here <3