Coder Social home page Coder Social logo

Minor issues in milopy tools about pertpy HOT 6 OPEN

theislab avatar theislab commented on June 14, 2024
Minor issues in milopy tools

from pertpy.

Comments (6)

emdann avatar emdann commented on June 14, 2024 1

Hopefully the new tutorial covers the use of contrasts to specify comparisons. I could add an example on subsetting to a certain lineage or something.

from pertpy.

emdann avatar emdann commented on June 14, 2024 1

In principle I agree with adding the diagnostic plots to the package, although in my head that's more material for extended tutorials since it needs some guidance for interpretation. But up to you guys to decide what fits in the package and what doesn't!

Unfortunately I am going to be slumped in response-to-reviewer work for the next ~ 4 weeks.

from pertpy.

Zethson avatar Zethson commented on June 14, 2024 1

@emdann let's tackle this at the hackathon, OK?

from pertpy.

Zethson avatar Zethson commented on June 14, 2024

@emdann I'd be in favor of dropping the subset_samples and subset_nhoods parameters. Do you think that there's a reasonable place and a need somewhere to mention this though? Like maybe in the docs?

from pertpy.

xinyuejohn avatar xinyuejohn commented on June 14, 2024

@emdann It would also be great to add plot_milo_diagnostics into milopy. I found this function is pretty helpful and has been used for several times in best-practice notebook.

from pertpy.

Zethson avatar Zethson commented on June 14, 2024

@emdann do you think that you'd have time to tackle this soonish?

from pertpy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.