Comments (3)
given time, I may be able to create a PR for this, but putting the issue in here for awareness while I am thinking of it
from puppet-puppet.
It's mentioned in https://github.com/theforeman/puppet-puppet#git-repo-support that it's needed. Soft dependencies in Puppet aren't great to say the least.
Perhaps it would be better to have something like extlib::has_module. So we can change this part here:
puppet-puppet/manifests/server/config.pp
Lines 253 to 254 in 01a716c
To
if $puppet::server::git_repo {
unless extlib::has_module('theforeman/git') {
fail('theforeman/git module is not present')
}
include git
Alternatively you could use load_module_metadata to load the metadata and verify the version is compatible. I can also imagine has_module
could be extended with another argument to verify the version.
from puppet-puppet.
Making it a hard dependency means it should to be visible to the end user also. Without having it visible in the dependencies on the forge it might be missed. By all means make it a hard dependency, but please consider adding it to the module metadata so it's picked up by the forge as well as some people will only do a cursory scan of the README and still miss that it has undefined dependencies.
from puppet-puppet.
Related Issues (20)
- please Allow puppetlabs/stdlib 7.x HOT 1
- puppet module is unusable at sites that do not have a compatible ::systemd namespace HOT 2
- camptocamp-systemd is deprecated HOT 2
- CONFIG setting in /etc/default/puppetserver isn't managed
- server::config class references wrong variable for additional_settings HOT 1
- SSL cert isn't created for compilers HOT 3
- incorrect handle of runinterval in agent/service/systemd.pp breaks catalog compilation HOT 3
- Ubuntu Focal fails to set max open file limit
- Make reporturl configurable
- Disable Dropsonde telemetry
- Please release new module version v16.3.0
- FreeBSD puppetserver gem-home is missing the system Gem.dir HOT 4
- updating puppetserver 6.x -> 7.x fails without manual intervention HOT 4
- Add support for sensitive config
- Add support for enabling unauthentacated access to metrics endpoint HOT 1
- Sync up with upstream naming (`master`->`server`) HOT 1
- missing CRL `put` from `puppetserver/conf.d/auth.conf` HOT 1
- Add support for local PuppetDB on every Puppet server HOT 1
- stdlib 9.x.x compat HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppet-puppet.