Provide more generic parser functions as separate module about puppet-foreman

[domcleal]

Yeah, they should probably go to stdlib if possible.

[aptituz]

Yes, indeed, if puppetlabs would include them. But an own module would be a good alternative, otherwise.

[ekohl]

We did talk about this in the past, but never got around to it. I do wonder how well puppetlabs likes cached_data because it caches on the master, so it doesn't work on multi master setup. One way to find out I suppose :)

[aptituz]

Well, not working properly in a multi-master setup is just one use-case. It's still useful in other (and certainly quiet common) use-cases.

[ekohl]

I fully agree it's useful.

[ekohl]

puppetlabs/puppetlabs-stdlib#521 has been opened, but the initial response isn't positive.

[ehelms]

This other option would be to re-purpose and use a puppet-common (we could rename) we have had for a while, e.g. theforeman/puppet-common#9

[ehelms]

Looks like they rejected that attempt to get the functionality into stdlib but suggested trying extlib. What are your opinions on putting it in extlib vs having our own module that contains common functionalities?

[aptituz]

Oh, never heard from extlib before.

Now that I'm aware of it's existence: Might indeed be a better place instead of stdlib. Do you know if it's being maintained in similar diligent way like stdlib?

I don't have a strong opinion weither to put it into your puppet-common module or extlib, but I'd hope it would make it to forge :) (and btw. puppet-common is a quiet over-generic name for a reusable module outside of katello, isn't it? :o)

[ekohl]

I could repeat what @aptituz said, but I fully agree.

[ehelms]

Based on your feedback, I moved it to extlib -- voxpupuli/puppet-extlib#17. Feedback on the design around namespacing or not would be greatly appreciated.

[aptituz]

Great. Will think about it and come back to you ASAP.

[ekohl]

cache_data has been pushed but has a different function signature so beware. I think we'll mention this in the changelog once we migrate. random_password should be done as well IMHO.

[ehelms]

My stab at moving random_password to extlib -- voxpupuli/puppet-extlib#19 (This one may make sense in stdlib, I just started where I left off)

[ekohl]

Given both PRs are merged in extlib, I'm considering this closed. Big thank you to @ehelms for fixing this.

[aptituz]

Thank from me aswell!