Comments (4)
I'm a bit hesitant to create different build for prod and dev since part of the incentive for the vendor package is to use the same artifact for both, but perhaps there's no good solution here.
from foreman-js.
I'm a bit hesitant to create different build for prod and dev since part of the incentive for the vendor package is to use the same artifact for both, but perhaps there's no good solution here.
Agree but I can't think about a better solution as well.
IMO we should support consumers in a transparent way:
rake webpack:compile # should use the `production` version
foreman start # should use the `development` version with `webpack-dev-server`
RAILS_ENV|NODE_ENV=production foreman start # should use the `production` version with `webpack-dev-server`
We can update the webpack.plugin.js so it will be transparent for consumers.
from foreman-js.
Ok, i guess that makes sense, as long as we can still run the production version in development if needed that's already better than what we have now (that node-production build differs from the release build)
from foreman-js.
This makes sense to me as well, we should also update any relevant documentation so people are aware of this.
from foreman-js.
Related Issues (14)
- Can't run individual tests HOT 2
- Provide Storybook deployment HOT 1
- Can't run tests when installing @theforeman/test from source
- tfm-stories stopped working after storybook v5.3 released HOT 1
- Snapshots are failing HOT 2
- can't run foreman storybook with link HOT 3
- Some @patternfly/react-core components aren't available in node_modules served by webpack HOT 1
- Include @patternfly/react-charts in foreman-js HOT 3
- The scss is not available when using `@theforeman/vendor-dev` HOT 1
- Warning: componentWillReceiveProps has been renamed...
- Testing Zapier zap
- Two versions of React ended in my bundle files when working with lerna link
- npm ERR! enoent ENOENT: no such file or directory '/.../@theforeman/env/bin/tfm-test.js'
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from foreman-js.