Coder Social home page Coder Social logo

Comments (4)

maximiliankolb avatar maximiliankolb commented on July 19, 2024

Instead of duplicating content, can we use curl in GHA and git checkout web my_file for local builds? If this is technically not feasable, I am not against duplicating it. I feel like the css is rarely touched anyway. We can probably get away with an IMPORTANT note in the README and a nice comment in the css files.

+1 for the idea and effort; I think it's definitely the right direction! I see this as a valid intermediate state towards Antora (which we can but don't have to use right away).

also +1 for changing the default branch to "develop" (like foreman) or "nighly" (like our URLs)

from foreman-documentation.

adamlazik1 avatar adamlazik1 commented on July 19, 2024

I'm OK with all other changes, but I don't see the benefit in renaming master to nightly. Then again, I guess there is not any issue with it either, so I probably wouldn't mind.

from foreman-documentation.

ekohl avatar ekohl commented on July 19, 2024

Instead of duplicating content, can we use curl in GHA and git checkout web my_file for local builds? If this is technically not feasable, I am not against duplicating it. I feel like the css is rarely touched anyway. We can probably get away with an IMPORTANT note in the README and a nice comment in the css files.

That's an interesting thought. Given how little they change I'd start with duplicating (given that's what we essentially already have today) and then later revisit dynamic retrieval.

I'm OK with all other changes, but I don't see the benefit in renaming master to nightly. Then again, I guess there is not any issue with it either, so I probably wouldn't mind.

It's to simplify cases like these:

- name: Set target name (master)
if: github.base_ref == 'master'
run: echo "TARGET_NAME=nightly" >> $GITHUB_ENV
- name: Set target name (stable branch)
if: github.base_ref != 'master'
run: echo "TARGET_NAME=$(echo ${GITHUB_BASE_REF} | tr / -)" >> $GITHUB_ENV

- name: Rename master to nightly
if: github.ref == 'refs/heads/master'
run: mv master nightly
working-directory: ./public

.replace("/master/", "/nightly/")

Essentially make the branch map 1:1 to the target.

from foreman-documentation.

adamlazik1 avatar adamlazik1 commented on July 19, 2024

Works for me.

from foreman-documentation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.