Callback not working with auto - Fix here about swipe

[ecurtis]

Adding an alert inside the callback confirms it fires if the auto rotation happens, however once you swipe it yourself no callback occurs, and the auto rotation does not resume.

[ecurtis]

In onTouchStart, you are recording information in this.start. You use this information in onTouchMove and onTouchEnd. However, this.start is previously defined as an important function. When I modified the code to record information in this.tstart instead, the start() function remained untouched and everything worked.

onTouchStart: function(e) {

  // cancel slideshow
  clearTimeout(this.interval);

  this.tstart = {

    // get touch coordinates for delta calculations in onTouchMove
    pageX: e.touches[0].pageX,
    pageY: e.touches[0].pageY,

    // set initial timestamp of touch sequence
    time: Number( new Date() )

  };

  // used for testing first onTouchMove event
  this.isScrolling = undefined;

  // reset deltaX
  this.deltaX = 0;

  // set transition time to 0 for 1-to-1 touch movement
  this.element.style.webkitTransitionDuration = 0;

},

onTouchMove: function(e) {

  this.deltaX = e.touches[0].pageX - this.tstart.pageX;

  // determine if scrolling test has run - one time test
  if ( typeof this.isScrolling == 'undefined') {
    this.isScrolling = !!( this.isScrolling || Math.abs(this.deltaX) < Math.abs(e.touches[0].pageY - this.tstart.pageY) );
  }

  // if user is not trying to scroll vertically
  if (!this.isScrolling) {

    // prevent native scrolling 
    e.preventDefault();

    // increase resistance if first or last slide
    this.deltaX = 
      this.deltaX / 
        ( (!this.index && this.deltaX > 0               // if first slide and sliding left
          || this.index == this.length - 1              // or if last slide and sliding right
          && this.deltaX < 0                            // and if sliding at all
        ) ?                      
        ( Math.abs(this.deltaX) / this.width + 1 )      // determine resistance level
        : 1 );                                          // no resistance if false

    // translate immediately 1-to-1
    this.element.style.webkitTransform = 'translate3d(' + (this.deltaX - this.index * this.width) + 'px,0,0)';

  }

},

onTouchEnd: function(e) {

  // determine if slide attempt triggers next/prev slide
  var isValidSlide = 
        Number(new Date()) - this.tstart.time < 250      // if slide duration is less than 250ms
        && Math.abs(this.deltaX) > 20                   // and if slide amt is greater than 20px
        || Math.abs(this.deltaX) > this.width/2,        // or if slide amt is greater than half the width

  // determine if slide attempt is past start and end
      isPastBounds = 
        !this.index && this.deltaX > 0                          // if first slide and slide amt is greater than 0
        || this.index == this.length - 1 && this.deltaX < 0;    // or if last slide and slide amt is less than 0

  // if not scrolling vertically
  if (!this.isScrolling) {

    // call slide function with slide end value based on isValidSlide and isPastBounds tests
    this.slide( this.index + ( isValidSlide && !isPastBounds ? (this.deltaX < 0 ? 1 : -1) : 0 ), this.speed );

  }

}

Cheers.

[ecurtis]

sorry for the odd formatting, just look for all the tstarts

[thebird]

I just updated your comments so I could read them easier. I'm looking into it right now.

[thebird]

Yea I completely forgot that the start namespace was already in use. I am changing the start() function to be renamed to begin().