[Bug] Crashes when passing huge list using -f about nthim

[TheBinitGhimire]

Hi there,

Can you please let me know the version of NtHiM that you are using? I couldn't reproduce the issue on the latest release version (v0.1.3), with a gigabytes large file as well as URLs with characters like %, ^, etc. and unicode characters.

Thanks,
@TheBinitGhimire

[TheBinitGhimire]

Hello @sumgr0,

I have successfully reproduced the issue as of now, for two different cases:

• Invalid characters in hostnames (as your error mentions): InvalidUriChar
• Very long hostnames (found during my testing): TooLong

This seems to be coming through the http crate, and src/uri/mod.rs file in this crate appears to have several other error types defined:

• InvalidScheme
• InvalidAuthority
• InvalidPort
• InvalidFormat
• SchemeMissing
• AuthorityMissing
• PathAndQueryMissing
• Empty
• SchemeTooLong

I have worked on a fix, and also pushed it to the development branch for now. The fix will be live in the next release of NtHiM.

Thanks for opening up this interesting issue!

Thanks,
@TheBinitGhimire

[TheBinitGhimire]

Hello @sumgr0,

The new release of NtHiM, i.e. v0.1.4, is published now, which includes the following fixes:

• Initial URL parsing crashes, and,
• Post URL parsing crashes!

If you are able to reproduce this issue in the new version of NtHiM, please re-open this issue and let me know!

Thanks,
@TheBinitGhimire