Coder Social home page Coder Social logo

Config method about tgm-plugin-activation HOT 6 CLOSED

tgmpa avatar tgmpa commented on September 17, 2024
Config method

from tgm-plugin-activation.

Comments (6)

thomasgriffin avatar thomasgriffin commented on September 17, 2024

Could we add all of these as parameters to tgmpa_register_plugins? Like this:

tgmpa_register_plugins( $plugins, $domain, $menu, $default_path, $strings );

I don't see any conflicts of doing this. Only plugins takes an array of plugins..everything else is just a single string.

from tgm-plugin-activation.

GaryJones avatar GaryJones commented on September 17, 2024

We could, but, if the developer only wanted to specify one particular string, he'd need to add values for everything preceding it.

Better would be:

tgmpa_register_plugins( $plugins, $config );

as then $config could be an array with keys for domain, menu, default_path and strings (with array values) or just whatever they want to overwrite. In that case, I'd suggest changing the function name to something simple like tgmpa() since this would then appear to be the only function that developers would ever need to call.

from tgm-plugin-activation.

thomasgriffin avatar thomasgriffin commented on September 17, 2024

Good point. And I like the idea of just having developers make one function call. tgmpa() makes sense, I say we go with that. I'll see what I can come up with.

from tgm-plugin-activation.

GaryJones avatar GaryJones commented on September 17, 2024

See pull request #22 :-)

from tgm-plugin-activation.

thomasgriffin avatar thomasgriffin commented on September 17, 2024

Well that was quick :)

from tgm-plugin-activation.

thomasgriffin avatar thomasgriffin commented on September 17, 2024

Closing this issue - fixed in dev.

from tgm-plugin-activation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.