Comments (5)
What pattern are you referring to? Did you want me to utilize LogicalPhenotype? Also, did you want me to break the file back into 2 files where one creates the transgenic_line details and then the other the cell phenotypes?
from pyontutils.
- In this case just the actual layout and scoping of the various parts of the code. Basically the top level control structure for neuron lang need to be in the top level of a file, not burried in a class. See for example.
https://github.com/tgbugs/pyontutils/blob/master/pyontutils/neuron_models/huang2017.py#L14
https://github.com/tgbugs/pyontutils/blob/master/pyontutils/neuron_models/huang2017.py#L19
https://github.com/tgbugs/pyontutils/blob/master/pyontutils/neuron_models/huang2017.py#L337
https://github.com/tgbugs/pyontutils/blob/master/pyontutils/neuron_models/huang2017.py#L338
You can run all your conversion logic inside the class as you do now, its just that all the 'top level' stuff needs to actually be at the top level because of how I implemented it (sort of for a good reason to force that information into places where it is more visible). - No.
- Yes please, name the transgenic lines file allen_transgenic_lines and stick it in the pyontutils/pyontutils folder.
from pyontutils.
L19. Is NeuronEBM and to create 2 different Neurons necessary then?
L337. allen_cell_types has Neuron.write() already at the end after all the Neurons were created. Unless that's not what you meant.
from pyontutils.
Ah, I was using L337 as an example of the scope of the call, which is independent of the ordering in the program, but it was clearly a bad example. You can call Neuron.write()
anywhere in the program and it will do the right thing. The issue is mostly with the fact that class NeuronACT needs to be declared after Config is called and also in global scope.
from pyontutils.
This is more or less resolved, any further fixes will be via the neurondm simple rework.
from pyontutils.
Related Issues (20)
- ttlfmt does not protect parentheses when formatting HOT 2
- neurondm npo ilx.partOf serializes as an owl:Class when it should not
- apinat-pops-more in apinatomy.org skips neurons that do not have any phenotypes in the spreadsheet HOT 1
- graphloading issue
- hierarchies should allow collapse for all duplicates HOT 1
- ttlser sporadic determinism failures
- figure out how to sanely set ontology local repo at runtime
- should prov for single files use the last commit per file or the current commit
- ttlser longer prefix issue HOT 1
- clifun args and defaults are backwards HOT 1
- merge pyontutils.sheets.Sheet with sparcur.datasets.Tabular and add caching when the version of record is remote
- stale curie map issue
- sheets.Sheet.update fails if target sheet is empty
- fix duplication of expression phenotype and neurotransmitter phenotype
- Merging some pythonutils parts up to RDFlib HOT 11
- npo entailed phenotypes -> subclasses
- broken documentation link http://ontology.doc/pyontutils/docstrings.html HOT 5
- scigraph load duplicates graph build directory
- sheets should warn more loudly on duplicate columns
- neurondm/modles/nerves.py change source sheet HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyontutils.