Coder Social home page Coder Social logo

Comments (3)

tfussell avatar tfussell commented on May 11, 2024

I've been using the library in-place so I never noticed this issue. It turns out we don't need to include miniz.h until we get into implementation files since I'm using a forward declaration in zip_file.hpp. My most recent commit should fix this for you. I'll close the issue if it works.

from xlnt.

Malvineous avatar Malvineous commented on May 11, 2024

I think that worked! I assume including miniz.h in zip_file.cpp isn't including all the code? Because miniz.c gets linked in as well, and that would include the same code twice. But it looks like miniz.h defines MINIZ_HEADER_FILE_ONLY which I assume means forward declarations only? If correct, then everything is good with your latest commit. Thanks for the fix!

from xlnt.

tfussell avatar tfussell commented on May 11, 2024

That's right. It's an unusual system, but it allows the whole library to be a single file. Happy to help!

from xlnt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.