Comments (7)
For example, if you click in the middle of a TextArea which does not have focus, then the cursor is briefly drawn at the end of the text before appearing where you clicked.
I can't seem to reproduce this issue, could you possibly share a screen recording of what you are seeing?
text-area-click-focus.mp4
from textual.app import App, ComposeResult
from textual.widgets import Button, TextArea
TEXT = """I must not fear.
Fear is the mind-killer.
Fear is the little-death that brings total obliteration.
I will face my fear.
I will permit it to pass over me and through me.
And when it has gone past, I will turn the inner eye to see its path.
Where the fear has gone there will be nothing. Only I will remain."""
class ClickFocusApp(App):
def compose(self) -> ComposeResult:
yield Button()
yield TextArea(TEXT)
if __name__ == "__main__":
app = ClickFocusApp()
app.run()
from textual.
This doesn't seem to work for me with the current Textual, but that's a separate issue.
This would suggest you've not installed devtools.
from textual.
Another example is ListView, where if you have a list view without focus where the action is to close the screen, then clicking on an item (other than the first) in the ListView will never show it as highlighted before it is destroyed.
Wouldn't you need a short delay before closing the screen to give the user chance to observe the selection? Something like this:
from textual import on
from textual.app import App, ComposeResult
from textual.screen import Screen
from textual.widgets import Button, Label, ListItem, ListView
class ExampleScreen(Screen):
def compose(self) -> ComposeResult:
yield Button()
yield ListView(
ListItem(Label("One")),
ListItem(Label("Two")),
ListItem(Label("Close this screen"), id="close-screen"),
)
@on(ListView.Selected)
def on_list_view_selected(self, event: ListView.Selected) -> None:
if event.item.id == "close-screen":
self.set_timer(0.2, self.dismiss)
class ClickFocusApp(App):
def on_mount(self) -> None:
self.push_screen(ExampleScreen())
if __name__ == "__main__":
app = ClickFocusApp()
app.run()
from textual.
Another example is ListView, where if you have a list view without focus where the action is to close the screen, then clicking on an item (other than the first) in the ListView will never show it as highlighted before it is destroyed.
I suspect this is one of those places where you'd use call_after_refresh
. For example, see how this looks:
from textual import on
from textual.app import App, ComposeResult
from textual.widgets import ListView, ListItem, Label
class ListViewMenuApp(App[None]):
def compose(self) -> ComposeResult:
yield ListView(
ListItem(Label("Beep"), id="beep"),
ListItem(Label("Close"), id="close")
)
@on(ListView.Selected, item="#beep")
def do_beep(self) -> None:
self.bell()
@on(ListView.Selected, item="#close")
def do_close(self) -> None:
self.exit()
if __name__ == "__main__":
ListViewMenuApp().run()
vs this:
from textual import on
from textual.app import App, ComposeResult
from textual.widgets import ListView, ListItem, Label
class ListViewMenuApp(App[None]):
def compose(self) -> ComposeResult:
yield ListView(
ListItem(Label("Beep"), id="beep"),
ListItem(Label("Close"), id="close")
)
@on(ListView.Selected, item="#beep")
def do_beep(self) -> None:
self.bell()
@on(ListView.Selected, item="#close")
def do_close(self) -> None:
self.call_after_refresh(self.exit)
if __name__ == "__main__":
ListViewMenuApp().run()
from textual.
Hmm. I concur that that simple example doesn't show the visual problem.
I suspect the issues I'm seeing are due to the focus causing a redraw in my app, then processing the mouse afterwards. I'll have to see if I can come up with a sensible reproduction case.
from textual.
@ZandevOxford Did you manage to resolve this in your app? It is difficult to help without a reproducible example - please do close this if no longer an issue.
from textual.
Sadly I've not had the time to investigate in detail.
I've had a quick look with textual 0.58.1 and note that I don't see this issue when running from the Mac terminal directly, but do see it in the Visual Studio Code editor.
My suspicion is that this might be regarded as an extremely minor bug in textual (in that I think it puts the cursor at the wrong position very briefly), but it's probably not visible in most terminals, and probably only visible in VS Code due to a quirk of how it does the updates.
Feel free to close this. I'll submit another one if I ever see a case where is causes something more serious than a brief flicker in VS Code.
from textual.
Related Issues (20)
- Can i do chart using sparkline? HOT 1
- Auto width results in zero-width when applied to `OptionList` HOT 2
- Footer in ModalScreen lists ignored App keybindings HOT 4
- `action_back` leads to empty screen when not using `_default` Screen HOT 2
- Content height of markdown does not take border/padding into account HOT 8
- Broken links in grid reference HOT 1
- DataTable not moving cursor into view when move_cursor invoked before scrollbar is visible in other screen HOT 1
- Running `App.run_test()` multiple times in separate `with` statements crashes. HOT 3
- Cover screen events in guide
- OptionList sizing issue
- Prevent mounting on unmounted widgets HOT 1
- Broken bindings after 0.61.0 HOT 3
- Header icon broken since 0.61.0 HOT 4
- Action lookup failing HOT 3
- Footer issue on 0.63.0 HOT 1
- Action lookup problems on 0.63.1 HOT 1
- Footer bindings invisible on app launch HOT 2
- UI freezes on screen dismissal with new Footer HOT 14
- Make textual apps pipeable by default HOT 1
- Add `isort` to dev dependencies HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from textual.