Coder Social home page Coder Social logo

Improve test coverage about rich HOT 8 CLOSED

textualize avatar textualize commented on May 18, 2024 3
Improve test coverage

from rich.

Comments (8)

willmcgugan avatar willmcgugan commented on May 18, 2024 7

Test coverage is now at 99% which is pretty good!

Thanks to @pim-hoeven for picking up the slack there.

There are still gaps in the progress bar, some of which will be tricky due to the dependency on threads. And plenty of one liners to pick up if anyone is interested.

from rich.

willmcgugan avatar willmcgugan commented on May 18, 2024 3

Coverage is currently 94%

from rich.

willmcgugan avatar willmcgugan commented on May 18, 2024 3

Coverage is at 98%. Missing coverage is mostly in rich.progress, which is a little challenging to test.

Still plenty of easy pickings if anyone wants to contribute.

from rich.

edraobdu avatar edraobdu commented on May 18, 2024 2

Hi Will, I just forked and ran the tests with coverage, and it shows a 91%, I know the higher the better, but isn't that an acceptable coverage rate to (at least) release the 1.0.0 version?

Note: I used coverage run -m --source=. pytest, see attached picture

In the mean time, I realized some required packages were not listed in the requirement.txt:
colorama==0.4.3
commonmark==0.9.1
typing-extensions==3.7.4.2

Screenshot from 2020-04-26 14-15-44

from rich.

willmcgugan avatar willmcgugan commented on May 18, 2024 1

Test coverage is currently 97% which is not bad at all. I'll integrate coveralls at some point so I can brag about it on the readme.

from rich.

willmcgugan avatar willmcgugan commented on May 18, 2024

Well its not bad... But I would like to be closer to 100%.

You can run the tests with make test which will also show the coverage.

I'll update the requirements. They're only needed for development, pyproject.toml stores the requirements for release.

from rich.

Edward-Knight avatar Edward-Knight commented on May 18, 2024

We now have 99.57% coverage, which isn't truely 100% coverage, but is now close enough to be rounded to 100%:

codecov

from rich.

willmcgugan avatar willmcgugan commented on May 18, 2024

Closing this. Coverage in 99th percentile. 🍻 Will try to keep it there.

from rich.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.