Comments (4)
goldbergyoni
commented on May 20, 2024
1
@DanielGluskin Great catch.
Somehow, during back and fourth of code, these issues sneaked to our code. What you observed indeed doesn't make sense, no reason to have both nock and spy over the same collaborator.
We're young and have no CI yet (@mikicho is working on that) so these things happen.
I fixed this in #38 and looking forward to hearing whether it worked for you (feel free to merge after approving)
p.s. We can't run different packages version since we have lock file. Also if you use nvm, then we lock Node version as well
@mikicho Maybe add to our contributing doc that one should run 'nvm use' before coding
from nodejs-integration-tests-best-practices.
mikicho
commented on May 20, 2024
I'll add a small contribution file
from nodejs-integration-tests-best-practices.
mikicho
commented on May 20, 2024
Isn't it closed by #38 ?
from nodejs-integration-tests-best-practices.
goldbergyoni
commented on May 20, 2024
Sure it is
from nodejs-integration-tests-best-practices.
Related Issues (20)
- Make TOC and recipe list (homepage) clickable
- Write last 3 best practices
- In Collab section - Write about yourself
- Create contributors table
- There are 2 api.js
- Create my-first-pr issues HOT 2
- MQ best practices HOT 2
- Create stale bot
- Create contributors bot
- Add more mySQL optimization flags
- Close sequalize connection in stopWebServer HOT 1
- Node Best
- Why mark `async` in the callback of `beforeAll`? HOT 1
- Nock with remote swagger HOT 1
- Lazy watch plugin
- VSCode snippets for integration tests
- DB cleanup recepie
- Create Fastify example HOT 1
- Put code examples
- put collaborators section HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nodejs-integration-tests-best-practices.