Comments (10)
@maddijoyce sending a PR right now with what I think they are, you can finalize it.
from react-testing-library.
It's possible you'll want to remove a bunch of README stuff and point it to dom-testing-library instead
from react-testing-library.
I'm in favor of this change and I see no reason to go forward with a PR and push a major version bump. This probably should have been filed in dom-testing-library
though because that's where the change will happen 😉 Though we'll need to do a major version bump of this lib as well to get that change.
from react-testing-library.
I'll add a link over there, too
from react-testing-library.
https://github.com/kentcdodds/dom-testing-library/pull/31/files
from react-testing-library.
Merged in https://github.com/kentcdodds/dom-testing-library/releases/tag/v2.0.0
- update types
- update examples
- new release
from react-testing-library.
Whoops, I probably shouldn't have just pushed an update to the version. I was being lazy. I'm pushing up a fix to the tests right now. We'll need an update to the types and examples. My bad :-/ Sorry about the laziness on my part.
from react-testing-library.
I was thinking that the types for dom-testing-library should probably exist in that repo and then be imported from there. I can write the types there if you like?
from react-testing-library.
That sounds great @maddijoyce, thanks!
from react-testing-library.
🎉 This issue has been resolved in version 3.0.1 🎉
The release is available on:
npm package (@latest dist-tag)
- GitHub release
Your semantic-release bot 📦🚀
from react-testing-library.
Related Issues (20)
- @testing-library/react TypeError: defineProperties is not a function HOT 4
- `result.current` shows `undefined` in console logger while rendering a custom hook HOT 2
- calling rerender causes remounting HOT 4
- ByRole have inconsistent results (getting h2 instead of button)
- ReactElement not assignable HOT 3
- Property 'toBeInTheDocument' does not exist on type 'JestMatchers<HTMLElement>' HOT 9
- queries returned by render are not scoped HOT 4
- Render function's typescript type excludes valid react component types
- Types are breaking HOT 12
- findBy* query fails but waitFor passes HOT 2
- Intial props not working when rendering a hook (or I've done something wrong.) HOT 5
- Snackbar not auto closing HOT 2
- Test results and "screen.debug" do not match
- Unexpected element not found when adding accessibilityElementsHidden or importantForAccessibility HOT 2
- SyntaxError: Cannot use import statement outside a module when using render or .tsx files HOT 2
- use rerender props in wrapper HOT 1
- Linting fails as "react-test-renderer" functions are interpreted as functions from "testing-library/react" HOT 2
- Calling render on a component that throws, results in 4 renders HOT 1
- React Testing library `unmount` is not working HOT 1
- Spurious `not wrapped in act` warnings from user-event, react, dom mismatch HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-testing-library.