Coder Social home page Coder Social logo

Comments (10)

MatanBobi avatar MatanBobi commented on August 17, 2024 2

We have an open PR to remove that: testing-library/testing-library-docs#1329
This was relevant back when peerDependencies weren't downloaded in case they weren't installed already.
You can safely remove @testing-library/dom from your devDependencies.
I'm resolving this one as it's a duplicate of the open issue in RTL (testing-library/react-testing-library#1216) and for the specific concern you've raised, we already have an open PR in the docs.
Thanks!

from dom-testing-library.

github-actions avatar github-actions commented on August 17, 2024 1

Uh oh! @joaopedrodcf, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

from dom-testing-library.

joaopedrodcf avatar joaopedrodcf commented on August 17, 2024 1

Thank you so much 🙏

from dom-testing-library.

MatanBobi avatar MatanBobi commented on August 17, 2024

Hi @joaopedrodcf.
The act error is from React Testing Library, is there any specific reason why you have DTL installed explicitly?
We have this issue that suggests it might be related to multiple DTL versions installed: testing-library/react-testing-library#1216

from dom-testing-library.

joaopedrodcf avatar joaopedrodcf commented on August 17, 2024

Wow, that was really quick @MatanBobi :D

Yeah, it was getting duplicated like this! After removing it, it works again 🥇

I think I saw it in next documentation but tried to look again but can't find it anymore maybe they updated their docs 😆

Gonna close the issue

from dom-testing-library.

joaopedrodcf avatar joaopedrodcf commented on August 17, 2024

Actually found the reason @MatanBobi why I add installed the @testing-library/dom.

In the docs of user-event they say that we need to install it:
https://testing-library.com/docs/ecosystem-user-event/

image

Even yarn will say that a peer dep is not met if we don't install it

image

from dom-testing-library.

github-actions avatar github-actions commented on August 17, 2024

Uh oh! @joaopedrodcf, the image you shared is missing helpful alt text. Check #1275 (comment).

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

from dom-testing-library.

github-actions avatar github-actions commented on August 17, 2024

Uh oh! @joaopedrodcf, the image you shared is missing helpful alt text. Check #1275 (comment).

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

from dom-testing-library.

joaopedrodcf avatar joaopedrodcf commented on August 17, 2024

Just to add more information for the issue:

image image

It can be seen in the yarn.lock the 9.0.0 was resolved to 9.3.1 and then 9.3.3 was the one I installed manually

So the solution for me was to basically relly in "resolutions" ( overrides in npm ) to force the same version and not having a warning in doing yarn because of a missing peer dependency

// package.json

{
    "devDependencies": {
        "@testing-library/dom": "9.3.3",
        "@testing-library/react": "14.0.0",
        "@testing-library/user-event": "14.5.1",
    },
    "resolutions": {
        "@testing-library/dom": "9.3.3"
    }
}

from dom-testing-library.

github-actions avatar github-actions commented on August 17, 2024

Uh oh! @joaopedrodcf, the image you shared is missing helpful alt text. Check #1275 (comment).

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

from dom-testing-library.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.