What to do about isnt() about test2-suite

[1nickt]

I use isnt in TODO tests quite often, when I don't care about what is returned so long as it isn't 'bar'.

TODO: {
    local $TODO = 'Question for Answer to the Ultimate Question of Life, The Universe, and Everything not known yet';
    isnt( question_for(42), 'How many roads must a man walk down?', 'The secret is out!' );
};

One of the main reasons I like it is the very clear error message:

not ok 1 - The secret is out! # TODO Question for Answer to the Ultimate Question of Life, The Universe, and Everything not known yet
#   Failed (TODO) test 'The secret is out!'
#   at foo.pl line 6.
#          got: 'How many roads must a man walk down?'
#     expected: anything else
...

[schwern]

How do we currently support something like:

my $id = $obj->next_id;
my $nextid = $obj->next_id;

isnt $nextid, $id, "next_id() returned a new id";

! only works for defined checks. Maybe what we need is not { ... }.

is $nextid, not { $id };

[petdance]

It simply passes if $left does not match $right in any way.

This is very useful. There are 156 uses of isnt in my codebase. Here are some examples:

my $custnum_district = get_test_district();
my $custnum_school = get_test_school();
isnt($custnum_district, $custnum_school, 'school and district are different customers');

or

isnt( price_for_flrid( $oldTitle->flrid() ), $newTitle->{price},
   'Old price is not equal to the updated payload price before renumber.' );

or

isnt( $list->total_price_local($kwd_ratesheet), $list->total_price_local($usd_ratesheet),
    'KWD is not same as explicit USD' );

or

isnt( $portrait->page_width(), $landscape->page_width(), 'page dimensions are different' );

I would be perfectly fine with the removal of the fake isn::t package and function so that you can no longer write isn't() calls.