Swift langage support about lizard

[terryyin]

Great idea! I’m going to implement it next week after I study the language a bit.

On 21 Jul 2015, at 3:29 pm, kenji21 [email protected] wrote:

We are using lizard on objc project (thanks you for this nice tool that improve xcode using a simple script), is there any chances that brand new Swift language will be supported ?

I have no idea on how to add support for it, maybe some indication will help to support it.

—
Reply to this email directly or view it on GitHub #61.

[kenji21]

Wow, nice :-D

[terryyin]

Hi @kenji21 ,
it has been a while. I finally did something with Swift.
I added a new option -l, which can filter the languages:
lizard -lswift <folder_name>

will analyse swift code only, otherwise it will process all file types it knows.

This is only a draft version for Swift support. I’m not sure if it’s completed yet. I don’t know much about Swift myself.
There’s at least one open issue, there seems to be nested functions in Swift,
is it common?
How do you want to count for nested functions?

terry

[kenji21]

Hi terry, nice to have some advancement on this.

Unfortunately I haven't switched to fulltime dev using swift yet. So I can't respond to your question.

Maybe having a look at these "swift grammar" files of the tailor project can help : https://github.com/sleekbyte/tailor/tree/master/src/test/swift/com/sleekbyte/tailor/grammar

[terryyin]

Thanks!

[kenji21]

Cool, it also can find swift and objc issues :

lizard --CCN 12 --ignore_warnings 20 --working_threads 4 -w
./ATvhClient/EPGCollectionViewLayout.swift:12: warning: durationInHourForItemAtIndexPath has 16 CCN and 1 params (71 NLOC, 595 tokens)
./tvheadend-ios-lib/tvheadend-ios-lib/SSHWrapper.m:214: warning: setPortForwardFromPort: toHost: onPort: has 29 CCN and 0 params (134 NLOC, 853 tokens)

[terryyin]

There’s also a new option -l to select the language, e.g.
lizard -lswift -lobjc

will only search for swift and objective-c code.

On 16 Dec 2015, at 4:18 PM, kenji21 [email protected] wrote:

Cool, it also can find swift an objc issues :

lizard --CCN 12 --ignore_warnings 20 --working_threads 4 -w
./ATvhClient/EPGCollectionViewLayout.swift:12: warning: durationInHourForItemAtIndexPath has 16 CCN and 1 params (71 NLOC, 595 tokens)
./tvheadend-ios-lib/tvheadend-ios-lib/SSHWrapper.m:214: warning: setPortForwardFromPort: toHost: onPort: has 29 CCN and 0 params (134 NLOC, 853 tokens)
—
Reply to this email directly or view it on GitHub #61 (comment).

[kenji21]

Ok, surprising that the EPGCollectionViewLayout.swift:12 is a method of an interface :

protocol EPGCollectionViewLayoutDelegate {
    func durationInHourForItemAtIndexPath(indexPath: NSIndexPath) -> Double
    func startDateForItemAtIndexPath(indexPath: NSIndexPath) -> NSDate
}

[terryyin]

Congrats! you just found a bug! Thanks.

I thought adding Swift shouldn’t be that easy… I will fix it asap.

On 16 Dec 2015, at 4:24 PM, kenji21 [email protected] wrote:

Ok, surprising that the EPGCollectionViewLayout.swift:12 is a method of an interface :

protocol EPGCollectionViewLayoutDelegate {
func durationInHourForItemAtIndexPath(indexPath: NSIndexPath) -> Double
func startDateForItemAtIndexPath(indexPath: NSIndexPath) -> NSDate
}
—
Reply to this email directly or view it on GitHub #61 (comment).

[terryyin]

Hi @Jenji21 ,

I just made a new release. It will be great if you can try it at your convenience.

terry

On 16 Dec 2015, at 4:27 PM, Terry [email protected] wrote:

Congrats! you just found a bug! Thanks.

I thought adding Swift shouldn’t be that easy… I will fix it asap.

On 16 Dec 2015, at 4:24 PM, kenji21 <[email protected] mailto:[email protected]> wrote:

Ok, surprising that the EPGCollectionViewLayout.swift:12 is a method of an interface :

protocol EPGCollectionViewLayoutDelegate {
func durationInHourForItemAtIndexPath(indexPath: NSIndexPath) -> Double
func startDateForItemAtIndexPath(indexPath: NSIndexPath) -> NSDate
}
—
Reply to this email directly or view it on GitHub #61 (comment).

[kenji21]

Just tried, now it's on the next method of the protocol (edit: which is the last one) :

lizard  --CCN 12 --ignore_warnings 20 --working_threads 4 -w
./ATvhClient/EPGCollectionViewLayout.swift:13: warning: startDateForItemAtIndexPath has 16 CCN and 1 params (70 NLOC, 585 tokens)

[terryyin]

do you mind send me the file or the context?

On 16 Dec 2015, at 4:45 PM, kenji21 [email protected] wrote:

Just tried, now it's on the next method of the protocol :

lizard --CCN 12 --ignore_warnings 20 --working_threads 4 -w
./ATvhClient/EPGCollectionViewLayout.swift:13: warning: startDateForItemAtIndexPath has 16 CCN and 1 params (70 NLOC, 585 tokens)
—
Reply to this email directly or view it on GitHub #61 (comment).

[kenji21]

Sure, this project will be open-sourced soon :-)

EPGCollectionViewLayout.swift.zip

[terryyin]

thanks for sharing.

Now the problem is fixed.

[kenji21]

Cool, seems to work well on Apple Lister sample:

https://developer.apple.com/library/ios/samplecode/Lister/Introduction/Intro.html

[foobra]

One question @terryyin
the function name is too short so we can't distinguish between functions

[terryyin]

@foobra could you also provide the swift code?

[foobra]

@terryyin

https://gist.github.com/foobra/f0a8cc1fcd3ef2081e1b6eb6cbc70e25
lizard -l swift -s cyclomatic_complexity -X demo.swift

[foobra]

@terryyin can we fix that?

[terryyin]

@pinguo_gaoshan if you know the solution, please send a pull request (don’t forget the tests). I won’t have time to look at this at least for this week (weekend maybe).

…

On 17 Aug 2017, at 5:47 PM, pinguo_gaoshan ***@***.***> wrote: @terryyin <https://github.com/terryyin> can we fix that? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#61 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAwJYtELB-eHrRIuH5Mp_W0C59wzCNj3ks5sZAtvgaJpZM4FckSQ>.

[nhkrishna5]

Hi @terryyin
How to create the custom file, to override "cyclomatic complexity number". In iOS Swift.

Like mentioned in
-T THRESHOLDS, --Threshold THRESHOLDS
Set the limit for a field. The field can be nloc, cyclomatic_complexity,
token_count, parameter_count, etc. Or an customized file. Lizard will
report warning if a function exceed the limit