Cards requirements control code review about terraforming-mars

[alrusdi]

Problems i found so far:

• Birds - allowed to be played even if there no players with plant production, game will lock on player selection phase
• BlackPolarDust - minor, asks for a space to place an ocean even if no oceans available
• BusinessNetwork - minor, but if player has no money to buy card he should have only option to discard it
• Cartel - counts tags even on Event cards - it is incorrect
• CloudSeeding - allowed to be played even if there no players with heat production, game will lock on player selection phase
• Comet - can lock game on player selection phase to remove plants if there no plants, does not provide an option to not remove any plants, forces to select a space for ocean if there are no oceans available
• ConvoyFromEuropa - forces to select space for ocean if there are no oceans available
• DeimosDown - forces to select player to remove plants even if there are no such players, does not provide an option to not remove any plants
• EnergyTapping - allowed to be played even if no players with energy production, game will lock on player selection phase
• EosChasmaNationalPark - forces to add animal to another card, if no such card, game will lock
• ExtremeColdFungus - has an option to add 2 Microbes to another card even if no such cards played
• Fish - allowed to be played even if no players with plant production, game will lock on player selection phase
• GHGProducingBacteria - has an action option to remove Microbes from it even if there no Microbes
• HeatTrappers - allowed to be played even if no players with heat production, game will lock on player selection phase
• Herbivores - allowed to be played even if no players with plants production, game will lock on player selection phase
• HiredRaiders - OrOptions nested in AndOptions it can cause a bug like with Sabotage #84
• IceAsteroid - forces to select space for ocean if there are no oceans available
• IceCapMelting - forces to select space for ocean if there are no oceans available
• ImmigrantCity - forces to select space for city if there are no places for cities on the board
• ImportedHydrogen - OrOptions nested in AndOptions it can cause a bug like with Sabotage #84
• ImportedNitrogen - refactor logic? it is not easy to understand
• Insulation - shows SelectAmount if player has no heat production
• LandClaim - can lock if there no places to claim
• LargeConvoy - OrOptions nested in AndOptions it can cause a bug like with Sabotage #84
• LocalHeatTrapping - has an option to add Animals even if there no Animal cards
• MiningExpedition - forces to select player to remove plants even if there no such players, does not provide an option to not remove any plants
• NaturalPreserve - forces to select a space for tile even if no such space available
• NitriteReducingBacteria - has an option to remove Microbes even if there are no Microbes on it
• NuclearZone - forces to select space for special tile if there are no such place on the Board
• OlympusConference - has an option to remove a science resource even if no such resource exists
• OpenCity - forces to select space for city even if no space for city available on the Board
• PermafrostExtraction - forces to select space for ocean if there are no oceans available
• Pets - check if this card cant be a target for actions like on Predators card to steal animals
• Plantation - forces to select space for greenery even if no greenery spaces available
• PowerInfrastructure - "Select energy to spend" should be read as "Select amount of energy to spend"
• PowerSupplyConsortium - playable even if there no Energy production available, locks the game
• Predators - should respect ProtectedHabitats and other exclusion
• ProtectedHabitats - check all Animal, Plants, Microbes cards and actions to be protected by this one
• ProtectedValley - text should be read like this "Select space reserved for ocean to place greenery tile"
• RegolithEaters - should not have an option to remove Microbes if there are not any Microbes on it
• SubterraneanReservoir - eagerly wants Ocean space to be selected disregard to oceans availability
• TollStation - incorrectly count tags on Event cards
• TowingAComet - forces to select space for ocean if there are no oceans available
• UndergroundCity - forces to select space for city even if no space for city available on the Board
• Virus - logic needs to be checked; at least, must provide an option to not remove any resources
• WaterImportFromEuropa - disallow action if there no ocean available

[vincentneko]

The game needs a getAvailableSpacesForCity as there are some placement rules for cities.

[alrusdi]

@vincentneko can you please implement it? Aslo it will be great if you take care about HiredRaiders, ImportedHydrogen and LargeConvoy cards. They may have the same bug as in Sabotage card described in #84

[vincentneko]

Yes, will try to do it when I have some time

[vincentneko]

Changes done in commit "Fix city spacing issue" on branch issue-81. Please review and merge if ok.

[alrusdi]

We are finally did it!