Coder Social home page Coder Social logo

Comments (9)

morgante avatar morgante commented on September 13, 2024

+1

from terraform-google-kubernetes-engine.

morgante avatar morgante commented on September 13, 2024

Fixed by #160

from terraform-google-kubernetes-engine.

chrislovecnm avatar chrislovecnm commented on September 13, 2024

We only added this feature for private clusters. Public clusters love binary auth too.

See #186

from terraform-google-kubernetes-engine.

morgante avatar morgante commented on September 13, 2024

This needs to be enabled on the beta modules.

from terraform-google-kubernetes-engine.

chrislovecnm avatar chrislovecnm commented on September 13, 2024

it was already out in as non beta, so if we do that it will be a breaking change. So let me know if you want me to put it in as a breaking change.

from terraform-google-kubernetes-engine.

morgante avatar morgante commented on September 13, 2024

No, it's only on the private cluster module (which uses the beta provider). We can add it to the public beta module as well, but we don't need to add it to the main module.

from terraform-google-kubernetes-engine.

chrislovecnm avatar chrislovecnm commented on September 13, 2024

I misunderstood. Terraform provider. Now the question is do we put this feature only into our beta modules, and remove it from the private template

from terraform-google-kubernetes-engine.

itlinux avatar itlinux commented on September 13, 2024

from terraform-google-kubernetes-engine.

morgante avatar morgante commented on September 13, 2024

@itlinux I think you might be looking in the wrong place. This issue is about adding a binary_authorization flag to the module.

from terraform-google-kubernetes-engine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.