Provide option to make ALB internal about terraform-aws-atlantis

[geota]

any progress/appetite to merge a feature like this? i would like to lock down ALB to make it fully internal, happy to submit a PR

[mlcooper]

I agree. I've been working with this module for the first time this week and just about have it up and running in my existing AWS VPC. What I did do is try to 'fool' it and gave it my private subnets for the ALB since I don't want this exposed externally. So the value I gave it for private_subnet_ids is the same as public_subnet_ids. I think it should work, but I'm not quite ready to test yet.

The use case for making this internal is because we run gitlab and github on-prem.

[mlcooper]

This worked...I had to fork this terraform-aws-atlantis repo and add

load_balancer_is_internal = true

to the module "alb" {} block.

[martinmosegaard]

Hi @geota . I am trying to get this working in a PR. Let me know what you think.

[antonbabenko]

This has been fixed in #99. Please use v2.9.0 which has been just released.

For some users, this release may require some ALB resource recreation described in ALB upgrade guide 5.0.

[kneufeld-pbp]

Was it by design to always use public subnets when internal is set to true? Our assumption was the module would use the private_subnet_ids when we provided the vpc_id; this assumption will error and our work-around is to add the set the public_subnet_ids with our private_subnet_ids

[antonbabenko]

@kneufeld-pbp This is just a bad name for the variable. Previously, there was no way to make ALB internal, so the public subnets were always used.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.