Coder Social home page Coder Social logo

Comments (4)

gosonzhang avatar gosonzhang commented on June 29, 2024

These are really places that needs to be aligned and modified. Can you mention a pr to see the specific modification point?

from tubemq.

tisonkun avatar tisonkun commented on June 29, 2024

Thanks for reporting this issue. In my opinion

catch (Exception e) {
            e.printStackTrace();
            logger.info("[loadTopicConfUnits error] ", e);
            throw e;
        }

we might be able to reduce e.printStackTrace() because stack trace is already logged by logger. The subtle difference is that e.printStackTrace() print stack trace in STDOUT. @gosonzhang please check whether our users rely on STDOUT output.

catch (Throwable t) {
            logger.info("Dispatcher start failed!", t);
            throw new ServletException(t);
        }

though usually we log exception in debug/warn/error level, Logger#info can also log exception as other level does. Here the concern is that change to warn might flood user log monitor if these logs are too much.

However, if you open a pull request for this kind of changes, we can deal with them case by case.

from tubemq.

aloyszhang avatar aloyszhang commented on June 29, 2024

@tisonkun Thanks for you reply.
I agree with that Logger#info can also log exception as other level does.
However , these several places of Logger#info means some error when loading master meta data from BDB StoreUnit.
So I think use Logger#error is the better way.

from tubemq.

tisonkun avatar tisonkun commented on June 29, 2024

Thanks for your explanation @aloyszhang ! Good contribution :-)

from tubemq.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.