Coder Social home page Coder Social logo

Comments (5)

pah avatar pah commented on May 17, 2024

Thanks for opening an explicit issue to track this. We have already discussed this in #91 and there is an (incomplete) patch available at pah/rapidjson-upstream@8005b55a.

Moving std::string instances to a Value won't work, though. The internal storage model is different between Values and std::strings and there is no way to move the raw data out of a std::string (even if we ignore the RapidJSON allocator support for now).

But at least temporary Value objects could be directly supported in AddMember and PushBack, which currently require an explicit call to .Move(), see Move semantics and temporary values.

C++11 move support would be useful for:

  • Value
  • Document, which implies
    • Allocator(s)
    • Stack(s)

from rapidjson.

pah avatar pah commented on May 17, 2024

Hum, why did you close it?

from rapidjson.

Kosta-Github avatar Kosta-Github commented on May 17, 2024

I think everything is captured in your pah/rapidjson-upstream@8005b55 patch and the std::string move is not possible...

from rapidjson.

pah avatar pah commented on May 17, 2024

Please reopen this issue to let us explicitly track the move support until we have completed and merged it, instead of some hidden discussion attached to a patch.

from rapidjson.

pah avatar pah commented on May 17, 2024

After the merge of #173, I think we can close this one for now.

from rapidjson.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.