Docker versions <1.13 don't work (conflicting `--rm` and `--detach` options to `docker run`) about telepresence

[itamarst]

Thanks for the bug report! I will take a look at this now.

[itamarst]

You mention conflict between --rm and --detach, was there additional output on stderr you based that on?

[exarkun]

Hmm I guess so. I think it was just what docker says if you manually run the command in the traceback though:

$ docker run --detach --rm -v /home/exarkun:/opt:ro -v /home/exarkun:/home/exarkun:ro -v /tmp/tmpjWD__K:/output datawire/telepresence-local:0.7 1000 s4-infrastructure '' ''
Conflicting options: --rm and -d
$

which matches all my other experiences with Docker. Those options don't work together.

I'll try to reproduce and paste exact transcript if that's useful.

[exarkun]

$ ./telepresence --deployment s4-infrastructure --docker-run leastauthority/grid-router
Starting proxy...
Conflicting options: --rm and -d

Looks like there's a bug in our code. Sorry about that!

Here's the traceback:

Traceback (most recent call last):
  File "./telepresence", line 197, in call_f
    return f(*args, **kwargs)
  File "./telepresence", line 227, in go
    tempdir, container_id = start_proxy(args)
  File "./telepresence", line 139, in start_proxy
    container_id = unicode(check_output(docker_cmd).strip(), "utf-8")
  File "/usr/lib/python2.7/subprocess.py", line 574, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
CalledProcessError: Command '['docker', 'run', '--detach', '--rm', '-v', '/home/exarkun:/opt:ro', '-v', '/home/exarkun:/home/exarkun:ro', '-v', '/tmp/tmpYUFsSC:/output', 'datawire/telepresence-local:0.7', '1000', 's4-infrastructure', '', '']' returned non-zero exit status 1


Would you like to file an issue in our issue tracker? We'd really appreciate the help improving our product. [Y/n]: 

[exarkun]

telepresence 0.7, Docker version:

$ docker version
Client:
 Version:      1.12.3
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   6b644ec
 Built:        Wed Oct 26 22:01:48 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.12.3
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   6b644ec
 Built:        Wed Oct 26 22:01:48 2016
 OS/Arch:      linux/amd64

[itamarst]

Docker 1.13 is apparently first version that supported --rm and --detach in concert. So will remove that.

[itamarst]

Fixed.