Coder Social home page Coder Social logo

Comments (9)

TelepathicGrunt avatar TelepathicGrunt commented on June 14, 2024

Do you have the datapack handy? I could take a look and see if it's formatted right.

The datapack should something like this:

Main Folder
   -pack.mcmeta 
   -data
       -repurposed_structures
           -loot_tables
                -chests
                     -<the new loot table files with the same name of the one to override>

from repurposedstructures-quilt.

TelepathicGrunt avatar TelepathicGrunt commented on June 14, 2024

Also, put the datapack in the world's datapack folder. Though resourcepack folder outside the saves folder might work too

from repurposedstructures-quilt.

TimelapsedEon avatar TimelapsedEon commented on June 14, 2024

I've done all of that, and even using an online JSON validator (jsonlint.com). I wish it was that simple. The datapack I'm making cross weaves treasures and recipes with other mods right now. I double checked both the structure and the spelling of all the files and folders. I'm trying to get a modded item to spawn in the end dungeons and a separate one in the end mineshafts so I can adjust the rate the players can find them. When that works out I'll adjust the non-end structure loot as well.
ProgressiveRecipes.zip

I think the current version only has the end mineshafts file wittled down to a single item for testing and it's still using the default table.

from repurposedstructures-quilt.

TelepathicGrunt avatar TelepathicGrunt commented on June 14, 2024

Hmm. I just took your datapack, cut everything out except for the badlands dungeon which I changed to

{
  "type": "minecraft:chest",
  "pools": [
    {
      "rolls": 10,
      "entries": [{
        "type": "minecraft:item",
        "weight": 20,
        "name": "minecraft:chain"
      }]
    }
    ]
}

and it seemed to have worked. I think the issue is that while the json is valid json, it's not setup right for vanilla as it is very picky. The latest.log file should have more info about which files is the problem. Can you put the end mineshaft loottable back into the chest folder, enter the world, and then post the latest.log file here? (use pastebin.com or post the actual file here).

I can read the log and it should help us figure out where the issue lies.

from repurposedstructures-quilt.

TimelapsedEon avatar TimelapsedEon commented on June 14, 2024

I couldn't replicate your success. Changed dungeon_badlands.json resaved the datapack, inserted it into the world Test3a: Lakes and buildings, used a command block with the command: " /setblock ~ ~1 ~ minecraft:chest{LootTable:"repurposed_structures:chests/dungeon_badlands",LootTableSeed:0} replace "(no quotes) to get me a chest with the loot from the badlands dungeon. Then when that showed no change, I teleported to the nearest badlands biome and found some dungeons and checked out their loot.
latest.log
2020-07-15_00 11 43
2020-07-15_00 11 49
2020-07-15_00 11 52
2020-07-15_00 12 11
2020-07-15_00 12 15
2020-07-15_00 12 21
2020-07-15_00 15 35

Screenshots in order: Chest 1, then 2 of first badlands dungeon. Proof of dungeon and biome it's in. Chest 1, then 2 of second badlands dungeon. Proof of dungeon and biome it's in. Loot from command block.

Any thoughts? I'm open to considering it's on my end and user error as this is the largest datapack I've ever made. Nothing should be interfering with your loot tables from any of the other mods or datapacks since their namespace isn't considered.

from repurposedstructures-quilt.

TelepathicGrunt avatar TelepathicGrunt commented on June 14, 2024

From the latest log file, here's the errors being thrown. It seems you might need the music disc mod on (paint) or that their item's ID is different than whats in. Or are the music discs in a different mod as paint sounds like its a painting kind of mod

[00:06:51] [main/WARN]: Found validation problem in {repurposed_structures:chests/dungeon_ocean}.pools[0].entries[1]->{minecraft:chests/underwater_ruin_big}.pools[2].entries[0]: Unknown loot table called paint:pcj/aquatic_discs
[00:06:51] [main/WARN]: Found validation problem in {repurposed_structures:chests/dungeon_ocean}.pools[0].entries[3]->{minecraft:chests/simple_dungeon}.pools[3].entries[0]: Unknown loot table called paint:pcj/alpha_and_beta_discs
[00:06:51] [main/WARN]: Found validation problem in {minecraft:chests/pillager_outpost}.pools[3].entries[0]: Unknown loot table called paint:pcj/beta_discs
[00:06:51] [main/WARN]: Found validation problem in {minecraft:chests/bastion_other}.pools[2].entries[0]: Unknown loot table called paint:pcj/nether_lena_raine_discs
[00:06:51] [main/WARN]: Found validation problem in {repurposed_structures:chests/dungeon_ocean}.pools[0].entries[3]->{minecraft:chests/simple_dungeon}.pools[2].entries[0]: Unknown loot table called paint:pss/staffs
[00:06:51] [main/WARN]: Found validation problem in {minecraft:chests/jungle_temple}.pools[1].entries[0]: Unknown loot table called paint:pcj/alpha_discs
[00:06:51] [main/WARN]: Found validation problem in {repurposed_structures:chests/dungeon_ocean}.pools[0].entries[2]->{minecraft:chests/underwater_ruin_small}.pools[2].entries[0]: Unknown loot table called paint:pcj/aquatic_discs
[00:06:51] [main/WARN]: Found validation problem in {minecraft:chests/underwater_ruin_big}.pools[2].entries[0]: Unknown loot table called paint:pcj/aquatic_discs
[00:06:51] [main/WARN]: Found validation problem in {minecraft:chests/underwater_ruin_small}.pools[2].entries[0]: Unknown loot table called paint:pcj/aquatic_discs
[00:06:51] [main/WARN]: Found validation problem in {minecraft:chests/simple_dungeon}.pools[2].entries[0]: Unknown loot table called paint:pss/staffs
[00:06:51] [main/WARN]: Found validation problem in {minecraft:chests/abandoned_mineshaft}.pools[2].entries[0]: Unknown loot table called paint:pcj/beta_discs
[00:06:51] [main/WARN]: Found validation problem in {minecraft:chests/woodland_mansion}.pools[4].entries[0]: Unknown loot table called paint:pcj/beta_discs
[00:06:51] [main/WARN]: Found validation problem in {minecraft:chests/bastion_bridge}.pools[4].entries[0]: Unknown loot table called paint:pcj/nether_lena_raine_discs
[00:06:51] [main/WARN]: Found validation problem in {minecraft:chests/desert_pyramid}.pools[1].entries[0]: Unknown loot table called paint:pcj/alpha_discs
[00:06:51] [main/WARN]: Found validation problem in {minecraft:chests/simple_dungeon}.pools[3].entries[0]: Unknown loot table called paint:pcj/alpha_and_beta_discs
[00:06:51] [main/WARN]: Found validation problem in {minecraft:chests/igloo_chest}.pools[2].entries[0]: Unknown loot table called paint:pcj/alpha_discs
[00:06:51] [main/WARN]: Found validation problem in {minecraft:chests/nether_bridge}.pools[1].entries[0]: Unknown loot table called paint:pcj/nether_c418_discs
[00:06:51] [main/WARN]: Found validation problem in {minecraft:chests/bastion_treasure}.pools[2].entries[0]: Unknown loot table called paint:pcj/nether_lena_raine_discs
[00:06:51] [main/WARN]: Found validation problem in {minecraft:chests/stronghold_crossing}.pools[1].entries[0]: Unknown loot table called paint:pss/staffs

For reference, this was the datapack that worked and replaced badlands dungeons loot with chains. I put it in the world's datapack folder and then started the game.
ProgressiveRecipes - test.zip

from repurposedstructures-quilt.

TelepathicGrunt avatar TelepathicGrunt commented on June 14, 2024

Ok I did more testing. This time, I removed all other loot tables besides repurposed structures. Then I put on the flight mod. Went to create a new world and hit the datapack button. Put in the datapack. Create world. And I was able to find the winged flight core so the datapack seemed to have worked. Maybe it's the other loot tables causing the whole thing to fail? If you want, I can make a vidoe later that shows me adding the datapack to the world to make sure no step is being missed or something. idk
ProgressiveRecipes - test2.zip

image

from repurposedstructures-quilt.

TimelapsedEon avatar TimelapsedEon commented on June 14, 2024

I'm going to investigate Paint's datapack, Paint's a username and does some large datapacks and I've already had an issue or two with them. Looks like it has modified the big and small underwater ruins tables that are referenced in your loot tables and it's got some issues with its own loot tables.
...
I haven't found the issue yet, but I can recreate your success in a completely blank new world with only my datapack. Looks like I get to go digging and adding one by one to see which datapack did it. Thanks for the help!

[edit] As far as I can tell it was an issue with a previous datapack's loot tables that had been deleted but I kept recreating the world instead of making a new one with the same seed for testing. A new world with the same seed and all the right commands produces the expected result. Appreciate the digging, it was indeed Paint's loot table references that were doing the issues.

from repurposedstructures-quilt.

TelepathicGrunt avatar TelepathicGrunt commented on June 14, 2024

Awesome! Glad you were able to find the issue. I'll close this now. :)

from repurposedstructures-quilt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.