Comments (17)
How are you requiring/importing deepmerge?
from deepmerge.
Are you using bower? is-mergeable-object
isn't on bower...
from deepmerge.
I'm not sure exactly what issue you were having, but I published 1.4.3 to inline is-mergeable-object for folks using bower who are trying to bundle the CommonJS entry point.
Let us know what your environment is @smarbiv, and whether or not 1.4.3 works for you.
from deepmerge.
Thanks for your quick response.
Yes, we do using bower and unfortunately the fix didn't solve the problem because when bringing it with bower the 'is-mergeable-object ' does not included..
from deepmerge.
1.4.3 no longer relies on you downloading the is-mergeable-object module - the code is inlined in every version of the file that is distributed on the npm registry.
Does bower not use the npm registry? Does it require that the built files be on Github? I'm not familiar with bower's workings at all.
from deepmerge.
hmm, at the very least, it looks like I forgot to update the main
field in the bower.json
from deepmerge.
Hi,
Bower uses tags, downloads the library and uses the main file you defined in your bower.json (in your case this is index.js). But this index.js is from your source code which is not packed with 'is-mergeable-object', so this is the reason why we can't use 'deepmerge' with bower..
from deepmerge.
I published 1.4.4 with an updated bower.json, let me know if that works for you.
What bundler are you using?
I didn't think to ask this when Bower was discussed before, but I'm curious what bundlers look at bower.json at all.
from deepmerge.
I'll assume everything is fine and dandy now :-)
from deepmerge.
Hi,
Sorry for the late response.
Unfortunately it didn't fix the issue.
We use bower to bring the package (using the git endpoint: "deepmerge": "https://github.com/KyleAMathews/deepmerge.git") and webpack for packing.
Because the 'dist' folder does not included in the git, the fix which use 'dist/umd.js' as the main file doesn't work for me.
Meanwhile we are using an older version of your module (1.3.2)
from deepmerge.
Could you depend on the unpkg link? https://unpkg.com/deepmerge/dist/umd.js
from deepmerge.
Yes, that works for me! :)
Thank you very much for all your help!
from deepmerge.
I wonder if there's something I could put in the bower.json that would save other bower users from running into this
from deepmerge.
Your fix in 1.4.4 could work if the file was exists, so adding the dist folder with the umd.js file to git maybe could be a solution..
from deepmerge.
Is bower support worth adding build artifacts to the repository?
from deepmerge.
I'm leaning towards no :-x
from deepmerge.
Merging #69 will officially drop Bower support via the Github repo.
from deepmerge.
Related Issues (20)
- How to use one object as target HOT 8
- Deno? HOT 7
- High CPU usage with large object merge HOT 1
- use recursive partial for type definitions HOT 1
- Will we ever see the v5? HOT 4
- When a particular property of the source object is undefined while the target one has a value, the value will be override by undefined HOT 2
- How to delete an element from an array with deepmerge. HOT 1
- How to avoid array concatenation HOT 18
- `is-mergeable-object` is a `devDependency` but used in `index.js` HOT 7
- An error occuren when merge axios config: config.signal.addEventListener is not a function HOT 3
- add ESM, support for module and browser HOT 5
- Possible to remove duplicate objects in arrays? HOT 1
- deepmerge_1.default) is not a function (No Webpack) HOT 4
- A class instance in an array in an object get formed into an object.
- It need filter on merge
- Add a way to merge into existing target object, just like Object.assign
- Feature Request: Passing a collision callback for colliding props
- [Feature request] Pass parent values to `customMerge()`
- When merging arrays the target defaults to empty array
- Doesn't play nice with React 19 RC
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deepmerge.