Coder Social home page Coder Social logo

Comments (3)

TehShrike avatar TehShrike commented on May 4, 2024

Both the alpha and bravo states are implicitly at route / because they don't have any parents with a route, and they don't have any route, and empty strings are treated as /.

All state transitions are triggered by a url change, so when the alpha state loads (prompted by navigating to the / route) and tries to initiate a transfer to the bravo state, it attempts to change the url... to /. Which doesn't trigger any "route changed" events, because it was already at that route. (And if it did trigger a route changed event, it would just load alpha again, because that's the first state at that route).

If you give the bravo state a route, and then load #/, it redirects to #/bravo and loads the state correctly.

from abstract-state-router.

ArtskydJ avatar ArtskydJ commented on May 4, 2024

If this is a user-error, I can accept that. Ideally, if we can note it in a simple way in the readme, that might be nice.

Does this mean that it is unsupported to navigate to another state with the same route? Right now I get this error:

router.on('stateChangeCancelled', e => console.log(e.message)) // => "This probably shouldn't happen, open an issue or something"

Maybe I should get an error like:

router.on('stateChangeCancelled', e => console.log(e.message)) // => "Unable to navigate to a state with the same route"

from abstract-state-router.

TehShrike avatar TehShrike commented on May 4, 2024

I think the reason you got that error is because you were throwing inside of the event handlers for the state change cancel/error, not because of the duplicate routes.

I'm not sure what an appropriate warning would be in this case - maybe "you attempted to navigate to route / but you were already there"? Maybe the hash-brown-router could emit an error or something if there were multiple handlers found for a route?

from abstract-state-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.