blend shape tracks don't work with SubdivMeshInstance3D about godot-subdiv

[tefusion]

Well they don't exactly work as intended. The importer now just has that converter script included at

godot-subdiv/project/addons/godot_subdiv/subdiv_converter.gd

Lines 33 to 54 in b1a8cba

	#blend shape tracks don't work with SubdivMeshInstance3D
	func convert_animation_blend_shape_tracks(anim_player: AnimationPlayer):
	for animation_library_name in anim_player.get_animation_library_list():
	var anim_lib:AnimationLibrary=anim_player.get_animation_library(animation_library_name)
	for animation_name in anim_lib.get_animation_list():
	var animation: Animation=anim_lib.get_animation(animation_name)
	for track_idx in range(0, animation.get_track_count()):
	if animation.track_get_type(track_idx)==Animation.TYPE_BLEND_SHAPE:
	var fake_anim=animation.add_track(Animation.TYPE_VALUE)
	var old_track_path=animation.track_get_path(track_idx)
	var node_name=String(old_track_path.get_name(0))
	var blend_shape_name=String(old_track_path.get_subname(0))
	var new_track_path=node_name+":"+"blend_shapes/"+blend_shape_name
	animation.track_set_path(fake_anim, NodePath(new_track_path))
	for key_idx in range(0, animation.track_get_key_count(track_idx)):
	var val=animation.track_get_key_value(track_idx, key_idx)
	var time=animation.track_get_key_time(track_idx, key_idx)
	var transition=animation.track_get_key_transition(track_idx, key_idx)
	animation.track_insert_key(fake_anim, time, val, transition)
	animation.track_swap(track_idx, fake_anim)
	animation.remove_track(fake_anim)

.

The only real disadvantage I see right now is that the tracks aren't blue, since it prefixes all tracks with blendshape you'd have to actively try to make a problematic property. No idea if blend shape tracks otherwise actually work differently.

Edit: If you meant the actual comment there: In the AnimationPlayer for blend shape tracks the node gets casted to MeshInstance3D, cause SubdivMeshInstance3D doesn't inherit from MeshInstance this converter code needs to run. Imo with the existence of BakedSubdivMesh not that urgent (cause that one uses the ArrayMesh, MeshInstance3D combo and offers fully godot compatible data)

[fire]

with the existence of BakedSubdivMesh not that urgent

Not so urgent. Closing