Comments (7)
Introducing API/ABI breaking changes in a patch release is really bad practice. This should have been done by adding a new function, like MP4Read2, with the additional argument. The way this has been done here, it not only breaks the API for C applications, but also breaks the ABI for every consumer of the MP4Read function, so the MP4v2 library cannot be updated from 4.1.3 to 4.1.4 or later without recompiling each and every dependency.
I understand that this repository contains a libmp4v2 fork for internal use at TechSmith and you're just publishing it here to comply with the license. In that case, you can of course break things as you wish without warning and as often as you like. That's totally fine.
The problem is, that this is not clearly stated anywhere and people started integrating this version of libmp4v2 into public repositories. The most prominent example is probably Arch Linux which ships with this version of libmp4v2.
It would be great if you could add a clear statement to your Readme.md explaining that this version is for internal use at TechSmith and you will introduce breaking changes at your discretion. Maybe even add a warning to not use this fork in public software repositories.
from mp4v2.
No but the usual distros have headed to enzo1982/mp4v2 (https://mp4v2.org/) which is more aligned with broad use.
from mp4v2.
I can confirm this also breaks Freeswitch mod_mp4v2 build:
making all mod_mp4v2
make[4]: Entering directory '/startdir/src/freeswitch-1.10.5/src/mod/applications/mod_mp4v2'
CC mod_mp4v2_la-mod_mp4v2.lo
In file included from /usr/include/mp4v2/mp4v2.h:58,
from mod_mp4v2.c:37:
/usr/include/mp4v2/file.h:336:32: error: expected ‘;’, ‘,’ or ‘)’ before ‘=’ token
336 | ShouldParseAtomCallback cb = nullptr );
| ^
make[4]: *** [Makefile:714: mod_mp4v2_la-mod_mp4v2.lo] Error 1
make[4]: Leaving directory '/startdir/src/freeswitch-1.10.5/src/mod/applications/mod_mp4v2'
from mp4v2.
MacPorts recently updated its mp4v2 port from the old 2.0.0 version to this TechSmith fork, unaware that it was not fully backward-compatible, and is now encountering this incompatibility in build failures of software that uses mp4v2.
This fork is the first result when searching GitHub or DuckDuckGo for "mp4v2". As such it is probably where many people will go when looking for this software. I agree with @enzo1982. I suggest that either this fork make itself compatible with historical mp4v2 once again, or else leave a prominent notice in the readme that this fork is not compatible with historical mp4v2 and/or that it is not intended to be used by the public.
The introduction of C++ features into the public headers does seem like a bug / oversight though that should be corrected. doc/MP4.3 still says:
The MP4 library can be used by either C or C++ programs. The calling convention is C,
from mp4v2.
ShouldParseAtomCallback cb = nullptr
should be
ShouldParseAtomCallback cb DEFAULT(nullptr)
for C to work
from mp4v2.
Has this issue been fixed?
from mp4v2.
@ryandesign Should we as well?
from mp4v2.
Related Issues (20)
- Project version number incosistency
- Chapter titles can be encoded in UTF-16
- mp4file.exe destroys .mpa/mp4 files.
- MP4TagsSetTVSeason with season set to null doesn't delete tvsn atom
- heap overflow in mp4v2::impl::MP4Integer32Property::Read HOT 4
- files lost or files size was 0Kb HOT 1
- Set duration on the file level
- Unable to determine total duration from chapter.txt
- Can mp4v2 encapsulate h265 HOT 8
- Question about chapter data
- Apple Silicon
- Build failures under GCC 10 HOT 7
- Documentation files do not exist
- ReadProperties: atom 'avcC' is too small; overrun at property: configurationVersion (src/mp4atom.cpp,399) HOT 2
- Doesn't read chapters defined in moov.udata.chpl HOT 3
- Cannot compile
- About MP4 file power failure problem
- Heap-buffer-overflow src/mp4property.cpp:338:17 in mp4v2::impl::MP4StringProperty::~MP4StringProperty() HOT 1
- Can mp4v2 be used to edit audio files in m4a format?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mp4v2.