Coder Social home page Coder Social logo

Comments (6)

bonbonio avatar bonbonio commented on May 29, 2024 2

Any idea if this could become a feature? I mainly want to avoid the position of this input changing, so maybe if there could be a way to make this render into another component or DOM item? like target=".list" or "target="#test"?

Its a great component though!

from material-ui-chip-input.

amit1911 avatar amit1911 commented on May 29, 2024 1

I'll try to work on it during this weekend

from material-ui-chip-input.

leMaik avatar leMaik commented on May 29, 2024

Good idea, PR welcome! 👍

from material-ui-chip-input.

amit1911 avatar amit1911 commented on May 29, 2024

Started working on this but turns out it requires more work than I thought. Just moving the chip rendering under the 'error text' display does't work as the styling get's messed up. Some of the issues that I noticed are:-

  • The chips overlap with the 'error text' display.
  • There is extra space under the floating label that was initially intended for chips.
  • Moreover, changing the chips element position might break someone's custom css due to change in component structure. For example, initially the chips could be styled by passing the className prop (let's assume className='mui-chip-input-root') and then using .mui-chip-input-root > div > div > div. But if we change the structure, then this css might not work. So we need to think about this as well.

There might be some other things to look into as well. So will need more time to do a detailed investigation. I might not be able to work on it in the next few weeks so if anyone else is interested please feel free to pitch in.

from material-ui-chip-input.

leMaik avatar leMaik commented on May 29, 2024

@amit1911 Thank you for trying, though! Material-UI currently gets a full rewrite, so maybe we should wait for them to finish before trying to implement this. The chip input needs to be re-written anyway because of all the breaking changes in the rewrite. 😕

Regarding the structure changes: I never officially supported using CSS for styling. There are supported style props that should be used for styling, so that wouldn't be a problem.

from material-ui-chip-input.

GlebVST avatar GlebVST commented on May 29, 2024

Hey guys, not all internal divs are supported with style props so right now you can't do everything you could do with CSS...
If you don't mind some SCSS, here is what I have for my chips-under:

.multiSelect {
  height: 200px;
  > div:nth-child(1) {
    padding-top: 8px;
    > div:nth-child(1) {
      > label {
        top: 18px;
      }
      > div {
        top:60px;
        position: absolute;
        max-height: 180px;
        overflow-y: auto;
      }
    }
  }
}

And

<Col xs={12} className={css.multiSelect}>
    <ChipInput      
            floatingLabelText="Type and select one or more practice areas"
            ...
    />
</Col>

2016-12-27 02 04 18 pm

If you don't want to support CSS, maybe add more internal style props?

from material-ui-chip-input.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.