TNTIndexer delete - Problem with total_documents about tntsearch

[nticaric]

It took me some while but finally we have a fix for this in v1.0.1

[nticaric]

A very good observation!! I'm working on a fix for this

[bbprojectnet]

Hi,

I think there is still a bug in total_documents counter.

I'm also using tnt with laravel scout, and when i multiple times import all records, total_documents increase everytime (number of records in DB is still the same).

For example, i have users table with 46 records.
First import: total_documents = 46
Second: total_documents = 47
Third: total_documents = 48
...

for another table total_documents increase by dozen for every import.

I think the problem may be in this part of code:

        $this->prepareAndExecuteStatement("DELETE FROM doclist WHERE doc_id = :documentId;", [
            ['key' => ':documentId', 'value' => $documentId]
        ]);

        $res = $this->prepareAndExecuteStatement("DELETE FROM wordlist WHERE num_hits = 0");

        $affected = $res->rowCount();

Shouldn't $affected depend on the first statment? not for second one?

If i fix this in that way:

        $res = $this->prepareAndExecuteStatement("DELETE FROM doclist WHERE doc_id = :documentId;", [
            ['key' => ':documentId', 'value' => $documentId]
        ]);

        $this->prepareAndExecuteStatement("DELETE FROM wordlist WHERE num_hits = 0");

        $affected = $res->rowCount();

it works as expected.

[nticaric]

Can you create a PR request please for this

[bbprojectnet]

Yes, sure.

But, is the change I proposed correct? I didn't analyze all the code in depth.

[nticaric]

Try to run the unit tests and see if all tests pass

[bbprojectnet]

Not pass, but also not pass without the fix :\

#269