Improve test code coverage of core components about teammates

[dlimyy]

Hi, could I work on the unit tests for DatepickerComponent and DatePickerFormatter? Thanks!

[blejkowski]

May I work on the tests for the AddingQuestionPanelComponent?

[lunoos]

Hi, i could work on test cases for CourseEditFormComponent.

[HarryLu33]

Hi, may I work on test cases for CommentEditFormComponent?

[ThomasGreen123]

Hi @cedricongjh , I'm new to OSS and would like to work on this as my first issue. I want to work on test cases for CommentRowComponent. May I take it?

[kenneySiu]

Hi is it okay if i can work on test cases for CommentTableModalComponent?

[JYH11]

Hi, is it fine to work on test cases for FeedbackPathPanelComponent? Thanks!

[Astrid641]

Hi, may I work on the CopySessionModalComponent? Thanks!

[MatheuMa]

Hey, can I work on ExtensionConfirmModalComponent?

u7632387 Workshop10 (This line is just a reference for workshop, please ignore)

[u7488099]

Hi, can I work on ErrorReportComponent? Thanks!

[u7505884]

Hello, may I work on the tests for the CommentTableComponent?

[cedricongjh]

hi @rushithapenikalapati, @skylar-mo and @WayyGood, do go ahead and submit a PR!

[cedricongjh]

Hi, could I work on the unit tests for DatepickerComponent and DatePickerFormatter? Thanks!

yup sure, go ahead! thank you :D

[cedricongjh]

May I work on the tests for the AddingQuestionPanelComponent?

yes, thank you!

[Miranda-lrx]

Hi, I'd like to work on adding tests for the CommentTableComponent. Thank you.
My id is U7763307, Workshop 10

[cedricongjh]

Hi, I'd like to work on adding tests for the AddingQuestionPanelComponent. Thank you. My id is U7763307, Workshop 10

hey @Miranda-lrx, i think @blejkowski (do let me know if you still are) is currently working on this, do pick another component to work on, and i'll assign it to you!

[Miranda-lrx]

Hi, I'd like to work on adding tests for the AddingQuestionPanelComponent. Thank you. My id is U7763307, Workshop 10

hey @Miranda-lrx, i think @blejkowski (do let me know if you still are) is currently working on this, do pick another component to work on, and i'll assign it to you!

I'd like to work on adding tests for the CommentTableComponent. Thank you.
My id is U7763307, Workshop 10

[Miranda-lrx]

Thank you, then may I choose the CommentTableModalComponent? Sorry I didn’t notice there were someone already selected the AddingQuestion task. I am willing to help with the issue! Josiiie ***@***.***>于2023年10月15日 周日下午5:06写道：

…

Hello, may I work on the tests for the CommentTableComponent? — Reply to this email directly, view it on GitHub <#12588 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BBSYQZ2NKEFSC7FFKBFLOYTX7N4OLANCNFSM6AAAAAA4WD25AE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[cedricongjh]

Thank you, then may I choose the CommentTableModalComponent? Sorry I didn’t notice there were someone already selected the AddingQuestion task. I am willing to help with the issue!

hey @Miranda-lrx, thats taken as well, there's still LogsHistogramComponent, which i've assigned to you, do let me know if that's ok

[Miranda-lrx]

Yes, please! Cedric Ong ***@***.***>于2023年10月16日 周一下午6:42写道：

…

Thank you, then may I choose the CommentTableModalComponent? Sorry I didn’t notice there were someone already selected the AddingQuestion task. I am willing to help with the issue! hey @Miranda-lrx <https://github.com/Miranda-lrx>, thats taken as well, there's still LogsHistogramComponent, which i've assigned to you, do let me know if that's ok — Reply to this email directly, view it on GitHub <#12588 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BBSYQZ2FXWN2YTHY5MWCIQLX7TQNTANCNFSM6AAAAAA4WD25AE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[siruwang]

Hi, @cedricongjh , I'd like to work on the test code of CommentVisibilityControlNamePipe, CommentVisibilityTypeDescriptionPipe, CommentVisibilityTypeNamePipe, CommentVisibilityTypesJointNamePipe. Could you please assign them to me. My uid is u7396183, workshop 3

[cedricongjh]

Hi, @cedricongjh , I'd like to work on the test code of CommentVisibilityControlNamePipe, CommentVisibilityTypeDescriptionPipe, CommentVisibilityTypeNamePipe, CommentVisibilityTypesJointNamePipe. Could you please assign them to me. My uid is u7396183, workshop 3

hey @siruwang, that has already been completed, i've assigned you LogsTableComponent if that's ok with you

[nikkixiong]

Hi, @cedricongjh , I'd like to work on the test of CourseRelatedInfoComponent! Thanks!
u7529454

[sdpunit]

Hi @blejkowski are you still working on AddingQuestionPanelComponent? If not @cedricongjh is it alright if I work on these tests. Thanks!

[cedricongjh]

Hi @blejkowski are you still working on AddingQuestionPanelComponent? If not @cedricongjh is it alright if I work on these tests. Thanks!

hey @sdpunit let's give @blejkowski another 2 days to respond, you can go ahead with working on the tests otherwise

[cedricongjh]

Hi, @cedricongjh , I'd like to work on the test of CourseRelatedInfoComponent! Thanks! u7529454

hey @nikkixiong that component already has 100% code coverage, i've assigned you the LogsDetails (all 4 classes inside the file) if that's ok with you

[sdpunit]

Hi, @cedricongjh , I'd like to work on the test code of CommentVisibilityControlNamePipe, CommentVisibilityTypeDescriptionPipe, CommentVisibilityTypeNamePipe, CommentVisibilityTypesJointNamePipe. Could you please assign them to me. My uid is u7396183, workshop 3

hey @siruwang, that has already been completed, i've assigned you LogsTableComponent if that's ok with you

Sorry I had taken other issue, mb. Could you please assign this issue to others. Sorry for the inconvenience.

In that case, I can work on LogsTableComponent as well until the next two days. If that's okay @cedricongjh

[cedricongjh]

Hi, @cedricongjh , I'd like to work on the test code of CommentVisibilityControlNamePipe, CommentVisibilityTypeDescriptionPipe, CommentVisibilityTypeNamePipe, CommentVisibilityTypesJointNamePipe. Could you please assign them to me. My uid is u7396183, workshop 3

hey @siruwang, that has already been completed, i've assigned you LogsTableComponent if that's ok with you

Sorry I had taken other issue, mb. Could you please assign this issue to others. Sorry for the inconvenience.

In that case, I can work on LogsTableComponent as well until the next two days. If that's okay @cedricongjh

Yes, go ahead

[090997]

Hi,could I work on LogsHistogramComponent and LogsTableComponent Testing?

[cedricongjh]

Hi,could I work on LogsHistogramComponent and LogsTableComponent Testing?

hello @090997, unfortunately these have been taken already

[anjum-edge]

Please test LogsTableContent again because it can contain bugs
Also check AddQuestionComponent because a new part of it can be deployed and can check the issues

[090997]

Hi,could I work on LogsHistogramComponent and LogsTableComponent Testing?

hello @090997, unfortunately these have been taken already

@cedricongjh Hi,Is there any other components that I can try to test?

[cedricongjh]

hi @090997 i've assigned you LogsLine for you to try to test

[nikkixiong]

@cedricongjh I already finished the LogsDetails testing and got all 100% covered on my computer, I will request for a PR soon.

[ThomasGreen123]

@cedricongjh，Can try to test question-response-panel.component.ts?

[cedricongjh]

hey @ThomasGreen123, feel free to take AddingQuestionPanelComponent

[kenneySiu]

Hi @cedricongjh I would also like to take on more tests if you have any available

[sdpunit]

hey

hey @ThomasGreen123, feel free to take AddingQuestionPanelComponent

Hey @cedricongjh I am working on AddingQuestionPanelComponent as well, since there wasn't any response from @blejkowski. However, I am happy for @ThomasGreen123 to work on it if he submits a PR before me, I'll request one tomorrow for LogsTableComponent and AddingQuestionPanelComponent subsequently.

[cedricongjh]

hey

hey @ThomasGreen123, feel free to take AddingQuestionPanelComponent

Hey @cedricongjh I am working on AddingQuestionPanelComponent as well, since there wasn't any response from @blejkowski. However, I am happy for @ThomasGreen123 to work on it if he submits a PR before me, I'll request one tomorrow for LogsTableComponent and AddingQuestionPanelComponent subsequently.

ah my bad! you can take that!

@ThomasGreen123, @kenneySiu give me a moment, i'll find new components for you to work on!

[cedricongjh]

hey @ThomasGreen123 and @kenneySiu i've assigned new components for you to work on! thank you for taking them up

[github-actions]

Good First Issue - Notes for Contributors
This issue is for first-time contributors only. If you are new to TEAMMATES, feel free to submit a PR for this issue.

Please note that we allow only one good first issue per contributor. If you have already made a prior contribution to TEAMMATES, you may wish to take a look at issues with the help wanted tag instead.

We do not assign issues to contributors. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it.

To get started, do read through our contributing guidelines carefully, and set up a development environment on your local machine before making a PR.

If you need any clarifications on our developer guide, or are facing issues that are not found in our troubleshooting guide, please post a message in our discussion forum.

[sarfophil]

Hello, May I work on the test for SingleStatisticsComponent?

[cedricongjh]

Hello, May I work on the test for SingleStatisticsComponent?

hi @sarfophil, do go ahead!

[xGREGKERSEYx]

Hello! Are there any open one's for Java?

[cedricongjh]

hi @xGREGKERSEYx, there's none open for Java at the moment, as the core team is working on migration of our Java backend

[abaduy123]

hi can I work on QuestionEditForm tests if it still available

[cedricongjh]

hi @abaduy123 feel free to!

[leyguan]

hi, may I work on QuestionResponsePanelComponent?

[cedricongjh]

hi @leyguan, do go ahead!

[Andy-W-Developer]

Hey, I would like to work on VisiblityPanel, thanks!

[cedricongjh]

hey @Andy-W-Developer, feel free to! here's an example PR on how we are currently doing unit tests: #12863, do follow it when implementing yours

[techMedMau]

Hi, may I work on ToastComponent?

[weiquu]

Sure @techMedMau, have edited the comment to assign the component to you

[techMedMau]

Hi, may I also work on ViewResultsPanelComponent?
I notice that the good first issue label is added, but I already tried working on it locally.

[cedricongjh]

hey @techMedMau, feel free to submit a pr for it

[rushithapenikalapati]

Hi, can I work on QuestionEditDetailsForm?

[skylar-mo]

Hi, may I work on the QuestionEditAnswerForm?

[WayyGood]

Hi! Can I work on PerQuestionViewResponsesComponent? thanks!

[kaioenzo]

Hi! Can I Work on QuestionSubmissionFormComponent?

[RohithSurya]

Hey Guys.. I would like to write tests for GqrRqgViewResponsesComponent and working on it

[ziqing26]

@kaioenzo @RohithSurya Hi feel free to submit a PR!

[WayyGood]

Hi! Got started on the coverage. Is there any special permission i need in order to submit a PR?

[rushithapenikalapati]

hi @rushithapenikalapati, @skylar-mo and @WayyGood, do go ahead and submit a PR!

When I push my changes upstream I'm getting an error that says "authentication failed"