rrrule#All() generates wrong recurrences around DST about rrule-go

[zensh]

It works well on my computer:

package main

import (
	"fmt"
	"time"

	"github.com/teambition/rrule-go"
)

func main() {
	rule, _ := rrule.NewRRule(rrule.ROption{
		Freq:    rrule.HOURLY,
		Dtstart: time.Date(2023, time.March, 26, 1, 30, 0, 0, time.Local),
		Until:   time.Date(2023, time.March, 26, 5, 0, 0, 0, time.Local),
	})
	recurrences := rule.All()
	fmt.Println(recurrences)
	// [2023-03-26 01:30:00 +0800 CST 2023-03-26 02:30:00 +0800 CST 2023-03-26 03:30:00 +0800 CST 2023-03-26 04:30:00 +0800 CST]
}

[yhabteab]

It works well on my computer:

From the outputs you provided, there is no DST changes on your computer. Otherwise, the 02:30 event wouldn't have appeared there. For comparison on my end (Mac Ventura), here's what it looks like. I just used the exact same program.

[
   2023-03-26 01:30:00 +0100 CET // Before 2 am, so no DST change
   2023-03-26 03:30:00 +0200 CEST // This is supposed to be 02:30, but there is no such time due to the daylight saving time change at 02:00.
   2023-03-26 03:30:00 +0200 CEST // The same event as the previous one
  2023-03-26 04:30:00 +0200 CEST
]

[zensh]

Some underlying code used UTC, Maybe you should do:

	rule, _ := rrule.NewRRule(rrule.ROption{
		Freq:    rrule.HOURLY,
		Dtstart: time.Date(2023, time.March, 26, 1, 30, 0, 0, time.UTC),
		Until:   time.Date(2023, time.March, 26, 5, 0, 0, 0, time.UTC),
	})

And then convert the results to CEST time