Json schma fails to validate perfectly good URL about jsonschema

[awwright]

You're probably looking for the uri format, JSON Schema doesn't provide for a "url" format. I'll take a look at why it seems there is one, though.

[tdegrunt]

Can you provide me with the original schema and object you validated?

[awwright]

it should be right there in the "errors" list:

{
    "schema": {
      "type": "string",
      "description": "The link for onboarding onto this feature.",
      "format": "url"
    }
    "instance": "http://getStartedWithAce.com/go"
}

It looks like validating against a format that doesn't exist always fails.

[tdegrunt]

Ah missed that, I'm on mobile. It's the url vs uri thing alright. We should probably error out on an invalid format then ... :)

[tdegrunt]

Reading here: http://json-schema.org/latest/json-schema-validation.html#anchor105

"The value of this keyword is called a format attribute. It MUST be a string. A format attribute can generally only validate a given set of instance types. If the type of the instance to validate is not in this set, validation for this format attribute and instance SHOULD succeed."

Should we just say it's valid?
If not .. and we want to error out: I have code ready to throw an SchemaError if an invalid format is passed, including test.

[awwright]

Yeah, it should probably normally succeed, same as unknown properties.

I'll make a PR for this as a test to the official test suite over the weekend, to formally run this behavior by other implementations.

[tdegrunt]

I think I have this fixed with the following (in develop branch):
14a8429

[acusti]

Seems like @tdegrunt’s fix for this has been orphaned in develop. Regarding whether unrecognized formats should fail or pass, I believe it is correct behavior that it passes, though I couldn’t find a test for it in the suite. Other validators (like tv4) take that approach, so I’m guessing that is correct.

I think a PR from develop into master would do the trick.