Comments (4)
Hey, @tcr. Just wanted to get some clarification on this. Is it duplicating the code in the Button Handler
section just like it's been done for h1, h2, h3
?
from edit-text.
@briankabiro Yeah! So to run down the list of what would need support added, it would be:
- Add a new entry in the button handler, as you mention, similar to
h1, h2, h3
- Add support in the schema.rs file for identifying
h4, h5, h6
as the RtfTrack::Blocks blocks type - Modify the markdown serialize and deserialize methods for supporting
h4, h5, h6
.
Incidentally, it looks like steps 2 and 3 are already done, so only #1 is left to do.
A stress test of using this is to run the server and client locally (./x.rs server --client-proxy
and in a separate tab ./x.rs client-proxy
) and then navigate to http://localhost:8000/$/multi/, which will display three clients at once, and click the 🙈🙉🙊
button at the top, which will hit buttons at random. This will stress-test the new button entries and make sure there's no surprising behavior after adding h4, h5, h6
support. For example, if the schema did not recognize these values, but there were buttons for it, it would panic. I believe there's no risk of that happening here, but still worth checking.
Let me know if I can add any more detail to these steps. An issue I haven't opened yet (but intend to) would be to add blockquote
support, for which steps 1, 2, and 3 would need to be followed, since there's no support yet. I can open that issue if it's interesting.
from edit-text.
Hey, thanks for the clarification. I've looked into it and added the entries in the Button Handler
.
I also ran the stress test after making the changes and left it to run for a couple of minutes. No panics during that time. Have opened a PR just now.
Also, +1 on adding the blockquote
issue, I could check it out later on. 😃
I'll read up on the steps you outlined above so that I can get a feel of how to do that.
from edit-text.
All set :)
from edit-text.
Related Issues (20)
- An in-range update of css-loader is breaking the build 🚨
- Chromedriver doesn't run in headless mode
- An in-range update of @types/react is breaking the build 🚨 HOT 4
- An in-range update of react is breaking the build 🚨 HOT 1
- Export typescript types for structs
- An in-range update of @types/react-dom is breaking the build 🚨 HOT 1
- An in-range update of @types/react is breaking the build 🚨 HOT 3
- If the user agent is Windows, the docs should rewrite themselves to use `.\tools`
- Deleting a selection over multiple list items panics HOT 1
- Going to http://sandbox.edit.io/?new=1 should open up a new page HOT 1
- Centralize custom cargo arguments in ./tools
- Running ./tools server after clone complains that `edit-text/dist` doesn't exist
- Clicking the editor too quickly while loading will throw an error
- Loading bar for webassembly load
- Process not killed when ./tools test integration finishes successfully
- Need test for load/save markdown dialog to see if it works HOT 1
- ./tools watch
- It's possible to partially select text
- Python 2 required
- End2End encryption?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from edit-text.