Coder Social home page Coder Social logo

Comments (11)

bterlson avatar bterlson commented on May 23, 2024

Worth noting that I believe this works with the fragment entry point currently as escapeHtml turns " into "

from ecmarkdown.

domenic avatar domenic commented on May 23, 2024

An alternate approach is to stop auto-codeifying strings everywhere. It doesn't gain you all that much. Thoughts? /cc @rwaldron @caridy @littledan who have been using Ecmark{up,down} in anger and possibly have experienced this issue enough to give feedback.

from ecmarkdown.

littledan avatar littledan commented on May 23, 2024

Why not auto-code-ify strings? I have been using an old version of ecmark{up,down} so I didn't actually see this feature yet.

from ecmarkdown.

domenic avatar domenic commented on May 23, 2024

Inside paragraphs you often use quotes for things that are not strings. Inside algorithms though it's almost always a real string. But e.g. check out the overzealous codeification in https://arv.github.io/ecmascript-object-observe/#solution

Other examples of where codeification would be wrong:

etc.

from ecmarkdown.

jmdyck avatar jmdyck commented on May 23, 2024

You could decide that only straight-quoted strings are auto-code-ified, and curly-quoted strings are left as-is. So in cases of overzealous codeification, change straight quotes to curlies.

from ecmarkdown.

domenic avatar domenic commented on May 23, 2024

Yeah, but then people have to type curlies (or use entities).

from ecmarkdown.

bterlson avatar bterlson commented on May 23, 2024

I think we should just get rid of codification of strings. Surrounding with backticks is ok. I'm confused at why it's backticks and not stars though. Why is true a value and a string code? See also #9.

from ecmarkdown.

bterlson avatar bterlson commented on May 23, 2024

Getting rid of codification will also make #17 easier probably.

from ecmarkdown.

rwaldron avatar rwaldron commented on May 23, 2024

Surrounding with backticks is ok.

Thats what I figured anyway? I don't think I've yet encountered the issues being discussed.

from ecmarkdown.

littledan avatar littledan commented on May 23, 2024

OK, SGTM

from ecmarkdown.

bterlson avatar bterlson commented on May 23, 2024

@domenic I plan to simply remove this. Will send PR.

from ecmarkdown.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.