roster_reminder.php warnings in 2.35.1 if new 2FA constants set about jethro-pmm

[jefft]

The problem is due to my adding to conf.php:

define('2FA_SENDER_ID','Jethro');

Jethro sees this and migrates the setting to the database:

jethro-pmm/include/config_manager.class.php

Line 19 in d52deeb

add_message("The setting ".$symbol." has now been migrated to the database and should be removed from conf.php");

resulting in the output:

SUCCESS: The setting 2FA_SENDER_ID has now been migrated to the database and should be removed from conf.php

However, apparently we're not allowed to emit content yet, as headers haven't all been set. Perhaps Config_Manager::init(); needs to defer its call a bit later in https://github.com/tbar0970/jethro-pmm/blob/master/include/init.php

Anyhow, I think 2FA_* variables are like SMS_* variables, in that they should be settable in conf.php and not overrideable in the System Configuration. See linked PR.