Coder Social home page Coder Social logo

Comments (5)

j042 avatar j042 commented on June 16, 2024

is this part of an existing test? a_s and b_s are flipped - jacobian determinants will be negative and you should at least use splines that aren't flipped

from splinepy.

deltaLuki avatar deltaLuki commented on June 16, 2024

is this part of an existing test? a_s and b_s are flipped - jacobian determinants will be negative and you should at least use splines that aren't flipped

No, this is a test from me. Does this mean that we don't need to consider the case where the patches are rotated 180 degrees?

from splinepy.

j042 avatar j042 commented on June 16, 2024

see Quick Start

...
The indexing of the control grid is defined by iterating
lower-indexed dimensions first. But if you prefer a
...

splines in your test case aren't doing that.

from splinepy.

jzwar avatar jzwar commented on June 16, 2024

Jacobians can be negative for multipatch geometries in these tests, as only the orientation is compared. However, I think the expected orientations vector might be wrong. From a quick drawing on a napkin I get

[0, 1, 1, 3, 1, 0, -1, -1]

from splinepy.

j042 avatar j042 commented on June 16, 2024

Nice. If you wanna add such test, please explicitly mark as negative jacobian multipatch test

from splinepy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.