Batman.js example about todomvc

[corroded]

https://github.com/Shopify/batman/blob/master/examples/alfred.html

here's the link to batman's alfred todo example. I'm thinking should we do this or do we wait for the shopify guys to upload on their own(since it is their app anyway)

Here's the corresponding ticket: https://github.com/Shopify/batman/issues/108

[ktusznio]

It probably makes more sense for you guys to write the example since you're more familiar with the nuances you're trying to explore in comparing the frameworks.

[addyosmani]

imo, taking the alfred todo example, stripping it down and then building it up to match the other todo apps might be the easiest way to get a batman.js example landed, but ideally we would try writing it from scratch.

[corroded]

im trying the writing from scratch way as the alfred example didn't really "conform" to the MVC standards. it was a quick example that had all the code in one html file only

[addyosmani]

Sounds good!. Let us know how you get on :)

[addyosmani]

@corroded Just checking in to see if you've had a chance to look at this yet. There are a few other frameworks that have submitted Todo apps for inclusion that we're in the process of getting through and I just wanted to see if Batman might be on it's way :)

[corroded]

heya, yup. im working on it but if there are others who can do it quicker then im good with it. i was having a hard time just doing a quick replica and have deferred to the groups for help but being in the alpha stage, it seems there are a few kinks to ron out?

[addyosmani]

Hey @corroded. That's cool. Is the general feeling over on the batman.js groups that it's at a place where it's stable to be used?. If not, I wouldn't be against including an example, but we would need to make it clear to users what they can expect if they opt to use it.

[corroded]

well part of the reason i can't progress is the groups are kinda silent right now. Im not sure what the devs are up to but maybe they're busy refining it so it can go to beta? Just a hunch though. I'll try to contact them again and ask help on the problem I;m having this week :)

[ktusznio]

@corroded: What are you having trouble with?

[corroded]

i've got no problems recreating the batman js todo app...but only if i follow their example to the dot. if i move out the code to the real "mvc" style, it breaks. i'll be trying to cloning batmanjs again and see if it will help.

[addyosmani]

I guess the broader question is whether Batmanjs encourages development using their style or whether they expect developers to greatly diverge from the pattern they appear to be advocating with their todo example.

[ktusznio]

@corroded: Another Shopifier recently released a Rails gem for Batman. Hopefully you find it helpful!

[corroded]

hi guys i recently just upgraded to the new batman js(an oct 12 release) and doing it the "right" way now works! there's some weird thing goign on with the delete though(it appears at the top before it disappears) but that's no biggie. I'll just implement the double click edit and the styles and we're all set :).

if anyone wants to help with the double click i can push it to my repo and someone can fork, but ill try to do those by the weekend here(+0800 GMT)

[addyosmani]

Sounds great @corroded!. I'll do a code review when you get a chance to make a pull request but it sounds like you've got a handle on the requirements for the app. At some point I'll probably create a little boilerplate pack to make it easier for anyone wishing to contribute todo examples for other frameworks :)

[addyosmani]

It's been a while since I've pinged regarding the batman.js example - is anyone currently working on this?

[addyosmani]

@corroded any luck on this issue?

[corroded]

heya guys sorry got tied up with wedding preparations. will be able to work on this again after i get back from the honeymoon. I'll try to push what i have so far so someone can take over?

[addyosmani]

No worries @corroded! If you could push what you have done so at that would be great. Thanks and enjoy the wedding!

[jipiboily]

Tell us when a working version get's pushed, I might take a look at it if I have time.

[addyosmani]

I was looking at the Alfred example again this weekend and I don't think it would take a huge amount of effort to get it in line with the other examples in TodoMVC. It's missing inline editing and multi-select for delete but perhaps we can target this for the example rewrites that are planned for version 1.0.

[sindresorhus]

@johnknott We've pulled in your Batman todo app in our Labs branch. Would you be interested in finishing it?

---

Here's is what needs to be done:

• Use the latest template
• Use the latest Batman version

• It's missing inline editing and multi-select for delete

• Routing
• Make sure you follow the newly released App Specification.
  Please let me know if anything is unclear or could be improved. It's not field tested yet. The spine.js example, not yet landed, can be used as a reference.
• This project uses tab indention and follows the Idiomatic guide to writing JavaScript. Please ensure your code follows this closely. If something is unclear, follow the existing style. Use double-quotes in HTML and single-quotes in JS and CSS.

[johnknott]

@sindresorhus Thanks for letting me know!

As you've noted the example I had up there is a bit dated and also isn't really very 'MVC'. There's also a bug where the 'x left' section doesn't update properly when a Todo item is removed from the collection. If I get chance I'll rewrite it to fit the new specifications but I am a bit busy at the moment so I'm not sure when that will be, unfortunately!

[sindresorhus]

@johnknott Ok, no problem :)

[addyosmani]

Hey @johnknott. Thanks a lot for replying to this thread. We would love to get the app rewritten when you get a chance. The only thing I'm really hoping to get fixed in our Labs version of it before pushing it out for people to play with is 'editing' (i.e double-click an item to edit it). It appears that there's most of the logic already in place to support the feature, but if you get an opportunity to look over the code at all and can let us know what's missing that would be great. Otherwise, I'll try patching up some of the minor bugs myself :)

[sindresorhus]

The version we pulled in is currently located on the labs branch.