Comments (6)
Hello, Mads!
This issue has been discussed many times (for example, โdrop minification in case of errorsโ). Just nobody reads the documentation.
from webmarkupmin.
I did read it, but I don't know how to use the NullLogger. Any code samples?
from webmarkupmin.
The NullLogger fixes the issue with the original repro step. However, add the following to any HTML reponse and it breaks again:
<?xml:namespace prefix />
from webmarkupmin.
Also, another issue with the NullLogger
is that it disables logging for everything in the application and not just WebMarkupMin. How about adding a Boolean property to the service options called something like options.ContinueOnError = true
from webmarkupmin.
Never mind. I got confused by the names ILogger
and NullLogger
which both exist in a MS nuget package
from webmarkupmin.
Hello, Mads!
<?xml:namespace prefix />
This error is handled correctly.
I got confused by the names
ILogger
andNullLogger
which both exist in a MS nuget package
Unfortunately, I began to use such type names still in 2013.
Expected
When an error occurs, simple just about the minification and serve the unminified. That way the page isn't broken and the user can see the content
In next release I will make NullLogger
the logger by default.
from webmarkupmin.
Related Issues (20)
- InvalidOperationException: Can not apply markup minification to text content, that was encoded in the 'gzip' format. HOT 4
- Internal html character being escaped HOT 4
- MarkupParsingException without log HOT 4
- Can't minify multiple documents in parallel? HOT 1
- .Net 6 Support? HOT 5
- Support Razor Pages HOT 10
- WebMarkupMin to minify javascript from string? HOT 1
- ๐๐ณ WebMarkupMin participates in the competition of open source projects ๐ณ๐ HOT 2
- Blank page response HOT 8
- License, compatibility with BSD HOT 3
- Minification breaks down all my page javascript? HOT 5
- No minify anything HOT 2
- problem dont use Quotes in Html Attribute HOT 2
- [WebMarkupMin.AspNetCore5] Sometimes a blank page is returned as the request has no response data available HOT 30
- Minified attributes seem to be double encoded HOT 4
- More a question, not an "issue" HOT 9
- .NET 7 broke BrotliCompressor due to invalid compression levels HOT 4
- ArgumentNullException: Value cannot be null. (Parameter 'destination') HOT 4
- Hmmmโฆ can't reach this page It looks like the webpage HOT 1
- object ref error with WebMarkupMin.AspNetCore7. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webmarkupmin.