Comments (2)
Not sure why but the issue goes away when removing async from this function (that doesn't have await in it anyway):
https://www.typescriptlang.org/play?#code/JYWwDg9gTgLgBAbzgYygUwIYzQJQgV2wBoV0tcIIY9C04BfOAMyghDgCIABGDAOwDOvZAGsA9GWQwAtK1pQOAbgBQy5BEHxWVGtjgBeUpmx4dBbAAoE9AJQrlGAQE8+yZvlcxgGuCCcARLAwAGQgMABM0KAsbAC44AAVWEGABNAAeJBABAHN4oShgPhyGAD5EZTg4dBh8KD5E5NS0ADp0AQgAGwA3NCtfXPiOAAs0Ts6IDgY7ZXpVdU04Is6iiloDI3JdPoRKuBy0GASMdD5qczR4mINy7XPaIj2wLGGhsSZKDkeqiYioq5sN18ASCoT+0RsLRgoz4Fgs4UB+nK4Ra2RyNketnsCyEcAARlAMKJDtsNqhjGtLLsqgcjic0GdtgCgXdtt84M9oW88ScvntfpEoPFHC43NckRUqlUcfBwkENhgAO4YYDwPyBXhgwUxKEwuEIoEotEzPZVGp1Bpy3gqKr0TEmmVwAD6y1WGowG1dfEprXwaS1UXdMWUYjEUrgAD0APxqDS4p0EokiQ7ujaJ4n3bAtP1oANQIMzIA
I generally wouldn't mix async/await with promise chaining - choose one and stick with it :)
from router.
That solves it for now, but probably more devs will face this inconsistency. await Promise.resolve('foo')
should be the same type as await Promise.resolve().then(() => 'foo)
, both should be Promise<string>
.
Additional hint, was using previously version 1.17.4
and this behaviour was OK. The regression was done between this and 1.26.3
from router.
Related Issues (20)
- The test does not work when rendering the router HOT 6
- File base subroutes regression HOT 4
- Context is undefined when search validation fails HOT 1
- Incorrect not found component being rendered HOT 3
- Overlapping Keys Cause Type Issues Using Experimental Intersection
- `Route.fullPath` is typed incorrectly when using path params HOT 8
- Undefined context after redirect HOT 6
- `beforeLoad` does not run when resetting from `errorComponent`
- `matchRoute` from `useMatchRoute` doesn't resolve TS type with pathless (layout) routes HOT 1
- [router-generator] index route underneath layout route inside of route group not working
- URIError: URI malformed HOT 5
- Issue with `useBlocker` when navigating to route with `beforeLoad` and `redirect`
- Updating to 1.34.9 causes issue with useRouter HOT 1
- Can't use $ route params when using Microsoft TFVC HOT 1
- Typescript: useRouteContext with strict: false
- SSR streaming is throwing error HOT 2
- `search` seems to be inferring the output type of the `validateSearch` instead of `z.input` HOT 1
- Unexpected behavior with not found component specified in the __root HOT 4
- Root route is rendered before loaders are finished HOT 2
- TanStackRouterDevtools broken when rendering inside of a shadow DOM HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from router.