Class constructor about structure

[talyssonoc]

Hello, @loweoj,

yeah, I didn't notice that when it was developed. The problem happens because when you try to set a value for the attribute inside the constructor, this will still be undefined: https://github.com/talyssonoc/structure/blob/master/src/attributes/descriptors.js#L25

A solution I can think for that is to always check if this[ATTRIBUTES] exists and, if no, set a value for that inside the getter. I'm not sure about the performance of that conditional tho (shouldn't be a problem). What do you think?

[loweoj]

You mean modify the setter for an attribute?

We just need instance[ATTRIBUTES] = Object.create(null); to be called before the instance constructor, or before attempting to set an attribute.

[talyssonoc]

That's the problem, we don't have an instance to assign it before the instance constructor. I mean modifying the getter of instance.attributes (which delegates to instance[ATTRIBUTES]) so it'll be always present.

[talyssonoc]

Hello, @loweoj! I've been working on Structure v2 (it's already in alpha in case ou wanna test) and I was thinking about a solution for that in v2. Would your proposed solution in #100 work for attributes with dynamic defaults, mainly if these dynamic defaults access instance methods?