Coder Social home page Coder Social logo

Comments (9)

waterplea avatar waterplea commented on August 14, 2024 1

We are currently working very hard to finish 4.0 so this won't be on our radar for a while. You can think on the fix in the meantime. I wonder if it's better to fix it in polymorpheus so it works everywhere. Current main in polymorpheus is the upcoming major release, fyi.

from taiga-ui.

waterplea avatar waterplea commented on August 14, 2024

Looks like the only way to fix it would be to wrap primitive values into objects, but that would be breaking change πŸ€”

from taiga-ui.

EricPoul avatar EricPoul commented on August 14, 2024

It can be wrapped only for components and templates but if it didn't work before could it be considered as a breaking change?πŸ˜„

from taiga-ui.

waterplea avatar waterplea commented on August 14, 2024

If we manage to do it only for components and templates β€” it won't be breaking :)

from taiga-ui.

EricPoul avatar EricPoul commented on August 14, 2024

I see that it could be for component only since template examples works https://github.com/taiga-family/ng-polymorpheus/blob/main/projects/ng-polymorpheus/src/directives/outlet.ts#L65

from taiga-ui.

waterplea avatar waterplea commented on August 14, 2024

It would work but you won't be able to get value of the error since templates can only access keys of the context object:

<ng-template #tmp let-value="key">{{ value }}</ng-template>

from taiga-ui.

EricPoul avatar EricPoul commented on August 14, 2024

Yep, so the goal is to try to wrap a primitive into the object for templates and components? It shouldn't be a breaking change for templates since it didn't work properly before(did work only if you hadn't reached a context). Is it a priority bug for you or should I consider making a PR?

from taiga-ui.

hakimio avatar hakimio commented on August 14, 2024

Why not just use @ngneat/error-tailor and avoid the tui-error boilerplate altogether?

from taiga-ui.

waterplea avatar waterplea commented on August 14, 2024

Moving it to ng-polymorpheus: taiga-family/ng-polymorpheus#449

from taiga-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.