Comments (9)
We are currently working very hard to finish 4.0 so this won't be on our radar for a while. You can think on the fix in the meantime. I wonder if it's better to fix it in polymorpheus so it works everywhere. Current main
in polymorpheus is the upcoming major release, fyi.
from taiga-ui.
Looks like the only way to fix it would be to wrap primitive values into objects, but that would be breaking change π€
from taiga-ui.
It can be wrapped only for components and templates but if it didn't work before could it be considered as a breaking change?π
from taiga-ui.
If we manage to do it only for components and templates β it won't be breaking :)
from taiga-ui.
I see that it could be for component only since template examples works https://github.com/taiga-family/ng-polymorpheus/blob/main/projects/ng-polymorpheus/src/directives/outlet.ts#L65
from taiga-ui.
It would work but you won't be able to get value of the error since templates can only access keys of the context object:
<ng-template #tmp let-value="key">{{ value }}</ng-template>
from taiga-ui.
Yep, so the goal is to try to wrap a primitive into the object for templates and components? It shouldn't be a breaking change for templates since it didn't work properly before(did work only if you hadn't reached a context). Is it a priority bug for you or should I consider making a PR?
from taiga-ui.
Why not just use @ngneat/error-tailor and avoid the tui-error
boilerplate altogether?
from taiga-ui.
Moving it to ng-polymorpheus: taiga-family/ng-polymorpheus#449
from taiga-ui.
Related Issues (20)
- π - Missing migration for `TuiBooleanHandlerWithContext<TuiMonth, TuiMonthContext>`
- π - `InputTime` has redundant assert log (dev mode only) if `maxValues` has non-default values HOT 2
- π - ΠΡΡΠ°Π΅ΡΡΡ Ρ ΠΎΠ²Π΅Ρ ΠΈ ΠΌΠ΅Π½ΡΠ΅ΡΡΡ ΠΊΡΡΡΠΎΡ Π½Π° readonly ΠΊΠΎΠΌΠΏΠΎΠ½Π΅Π½ΡΠ΅ HOT 1
- π - ComboBox - list is not displayed HOT 1
- π - `Multiselect` clears value on press `,`
- π€ - Property Use Logical HOT 1
- π - ng add nx18
- π - sensitive bug
- π - focus removed from editor when clicking disabled buttons in toolbar
- π€ - SSG issue
- π - calendar does not display cells correctly
- π - `InputTime` default 00 minutes are not set in HH:MM mode
- π - Error after migration to 4.0 : Property 'items' in type 'TuiDataListGroupWrapperComponent<T>' is not assignable to the same property in base type
- π - tui-root with background does not allow integration with other root elements and causes a white screen (v4.0) HOT 2
- π - `Documentation` invalid url on v3 HOT 1
- π - Create directive `tuiLike`
- π - TuiCalendarRange change does not update checkbox position
- π - remove duplicates in import after ng-update
- π - Links to documentation do not work HOT 2
- π - `API` page `CalendarRange` changing input [defaultViewedMonth] not working
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from taiga-ui.