Comments (7)
I kind of agree with @ivensdenner. My preferred usage is:
if let v = element["MyString"] {
print(v.stringValue)
}
from aexml.
Hi all, thanks for this discussion.
In the latest version (3.0.0) I've improved error handling logic to be as you recommended here, that is:
- there is no
errorElementName
anymore - subscript returns empty element (value = nil and stringValue = "")
- this empty element will have
error
property different then nil
Feel free to comment this change if you find anything suspicious (unit tests are passing but this can make breaking changes in other people code, that's why it's a major version bump).
This issue can be closed now.
from aexml.
Hmmm, I think I agree. :)
This will be left open for now, maybe I'll change that in some upcoming version.
from aexml.
What about the subscript returning an optional type? It sounds more natural to me.
from aexml.
No, that's what I wanted to avoid from the initial version. It's easier for end users when subscript is not an optional. And problem with empty string is that you couldn't differentiate when something really has no value or the complete element is missing.
from aexml.
Helped myself with:
extension AEXMLElement {
var string: String? {
if name == AEXMLElement.errorElementName { return nil }
return stringValue
}
}
from aexml.
In SwiftyJSON, there are two getters: string: String?
and stringValue: String
. The equivalent of SwiftyJSON's string: String?
is AEXMLElement's value: String?
, except that in SwiftyJSON if there's an error, string: String?
will be nil
instead of an error message. AEXMLElement can be made to mimic SwiftyJSON if subclassed like below:
class MyAEXMLElement: AEXMLElement {
override var value: String? {
get {
guard name != AEXMLElement.errorElement else {
return nil
}
return super.value
}
set {
super.value = newValue
}
}
override var stringValue: String {
guard name != AEXMLElement.errorElement else {
return ""
}
return super.stringValue
}
}
And SwiftyJSON handles the errors by having an explicit error property, in case you want the actual error:
extension MyAEXMLElement {
var error: String? {
guard let value = value where name == AEXMLElement.errorElement else {
return nil
}
return value
}
}
Of course, I'm not saying the above is exactly how I think it should be implemented. I'm only showing how I would adapt the existing code to behave like SwiftyJSON.
from aexml.
Related Issues (20)
- module compiled with Swift 5.0 cannot be imported by the Swift 5.1 compiler. HOT 3
- could not find module 'AEXML' for target 'arm64-apple-ios'; found: x86_64 HOT 1
- AEXMLDocument Retain Cycle
- XML incomplete parsing
- module compiled with Swift 5.1 cannot be imported by the Swift 5.1.2 compiler HOT 6
- module compiled with Swift 5.1 cannot be imported by the Swift 5.1.2 compiler HOT 4
- Add child with end tag HOT 1
- Support for DTDs? HOT 4
- Parser doesn't handle "0" or "1" for Booleans HOT 1
- Sorted attributes
- Build Target out of date HOT 3
- AEXML.modulemap not found on iOS 14 HOT 4
- Xcode 12 build warning - 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0 HOT 1
- Question
- Ability to exclude standalone attribute from document header HOT 3
- When <ruby> elements are used in html, other texts are vanished. HOT 1
- Error while parsing large files on linux
- Apple Silicon support HOT 4
- Privacy Manifest HOT 1
- Could not find module 'AEXML' for target 'x86_64-apple-ios-simulator'
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aexml.