Comments (4)
It seems that changing line 35 in AEXML.swift to
private(set) weak var parent: AEXMLElement?
"fixes" the memory leak.
But this is not a clean solution, since now a parent object can become nil even if it has children. The parent reference in AEXMLElement should rather be an unowned reference, but then the parent cannot be optional and the code would have to be refactored accordingly.
I am stil rereading again and againt the chapter about ARC in the Apple Swift Book myself ;)
from aexml.
Hello,
first of all, thanks for the feedback, it's a good one.
I did some testing with your example, and it's behaving as you said.
parent
property on AEXMLElement is optional by design, because AEXMLDocument (inherited from AEXMLElement) has no parent (it's parent property is set to nil on initialization).
Because of that I believe that solution you recommended (weak reference for parent property) is a way to go, because it will resolve strong reference cycle between AEXMLElement and parent (also AEXMLElement), but it will also allow parent to be nil when it needs to (AEXMLDocument).
If you want, you can send me a pull request with this fix, or I'll do it later.
Cheers,
// T
from aexml.
Just made my first pull request. Yay! ;) Please see comment in the request.
Thank you for AEXML and best regards, Georg
from aexml.
I'm glad you did. :)
I'll close this issue now, because it has been fixed via this pull request.
Cheers,
// T
from aexml.
Related Issues (20)
- module compiled with Swift 5.0 cannot be imported by the Swift 5.1 compiler. HOT 3
- could not find module 'AEXML' for target 'arm64-apple-ios'; found: x86_64 HOT 1
- AEXMLDocument Retain Cycle
- XML incomplete parsing
- module compiled with Swift 5.1 cannot be imported by the Swift 5.1.2 compiler HOT 6
- module compiled with Swift 5.1 cannot be imported by the Swift 5.1.2 compiler HOT 4
- Add child with end tag HOT 1
- Support for DTDs? HOT 4
- Parser doesn't handle "0" or "1" for Booleans HOT 1
- Sorted attributes
- Build Target out of date HOT 3
- AEXML.modulemap not found on iOS 14 HOT 4
- Xcode 12 build warning - 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0 HOT 1
- Question
- Ability to exclude standalone attribute from document header HOT 3
- When <ruby> elements are used in html, other texts are vanished. HOT 1
- Error while parsing large files on linux
- Apple Silicon support HOT 4
- Privacy Manifest HOT 1
- Could not find module 'AEXML' for target 'x86_64-apple-ios-simulator'
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aexml.