Coder Social home page Coder Social logo

Comments (29)

kcdtv avatar kcdtv commented on August 16, 2024 3

We can close it now: corrective patch have been merged in last update, clean compilation, not a single warning. GJ vk! (cf 86a45b5)

from reaver-wps-fork-t6x.

pchk avatar pchk commented on August 16, 2024

#63

from reaver-wps-fork-t6x.

blshkv avatar blshkv commented on August 16, 2024

nop, not fixed:

GIT update -->
   repository:               https://github.com/t6x/reaver-wps-fork-t6x.git
   updating from commit:     6e60ee25e86ec798de2e23971b029d555e9dc398
   to commit:                ed98a9503f1d50b4b61fe1bbc38f6c29fa8c784f

 * QA Notice: Package triggers severe warnings which indicate that it
 *            may exhibit random runtime failures.
 * common.c:614:5: warning: implicit declaration of function ‘wps_pin_checksum’ [-Wimplicit-function-declaration]
 * md5-internal.c:185:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
 * md5-internal.c:186:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
 * md5-internal.c:191:29: warning: argument to ‘sizeof’ in ‘memset’ call is the same expression as the destination; did you mean to dereference it? [-Wsizeof-pointer-memaccess]
 * wps_dev_attr.c:344:3: warning: implicit declaration of function ‘mac2str’ [-Wimplicit-function-declaration]
 * wps_dev_attr.c:364:3: warning: implicit declaration of function ‘pingen_zyxel’ [-Wimplicit-function-declaration]

from reaver-wps-fork-t6x.

blshkv avatar blshkv commented on August 16, 2024

Please open the bug so that you won't forget about it

from reaver-wps-fork-t6x.

kcdtv avatar kcdtv commented on August 16, 2024

About the "implicit declaration of a function" it is just a warning
It means that for this function the compiler has not seen a declaration ("prototype") yet:
http://stackoverflow.com/questions/8440816/warning-implicit-declaration-of-function
For example if you use the algorithm from 'pingen_zyxel' you will see that it works even if the declaration was not perfect.
About "dereferencing type-punned " that's more complex (for me who doesn't know C) and could lead to bugs in very specific contexts.
http://stackoverflow.com/questions/3246228/dereferencing-type-punned-pointer-will-break-strict-aliasing-rules

from reaver-wps-fork-t6x.

blshkv avatar blshkv commented on August 16, 2024

I like your "just a warning" attitude. Do you ignore all warnings in your life? What's the reason of the warning?

from reaver-wps-fork-t6x.

kcdtv avatar kcdtv commented on August 16, 2024

I like your "just a warning" attitude

đŸ˜ș

Do you ignore all warnings in your life?

Very often: Fear and conformity is the enemy. They are limitations: Living is about taking risks from time to time đŸ˜Œ
I stop joking: You can see a lot of warnings of this kind compiling a lot of stuff... And when you install them it works.
Compilation was not perfect but if you can install and if the tool works...

What's the reason of the warning?

I don't know C so I can't tell much more than what i said before
And you'd better read the threads that I linked in my previous answer than to rely on me who does not know at all C programming and "the art of clean compiling"
What I know is that C requires a precise code organization it is not very (at all?) flexible .
When you see
* warning: implicit declaration of function ‘pingen_zyxel’*
It means that in one of the file created (or used) to generate the PIN "zyxel" (Name is not good: Zyxel is a branch from tehcnicolor and this algorithm was first seen on Tenda router by ZaoChesung) the function "pingen-zyxel" was not declared properly for the compiler.
Which is not realy a problem, declaration is done implicitly instead of explicitly, the compiler can handle it.
Yes, the code would be nicer and compilation more fluent if it was perfectly written,
No, it is not a bug stricto sensus
Try the pingen for zyxel and you will see that it works...
[+] Waiting for beacon from F8:8E:85:40:84:95 [+] Switching wlan0mon to channel 1 [+] Associated with F8:8E:85:4:smiley_cat: (ESSID: MOVISTAR_:cat:) [+] Starting Cracking Session. Pin count: 0, Max pin attempts: 11000 [+] Trying pin 12345670. [+] Sending EAPOL START request [+] Received identity request [+] Sending identity response [P] E-Nonce: 89:bc:5a:57:e2:3d:b4:93:1c:0f:d5:ea:df:a5:2a:39 [P] PKE: 55:3f:a2:5e:12:cf:ec:45:44:ce:31:24:a1:22:01:ba:1f:3a:ec:d1:63:76:cc:c0:3d:39:bc:a7:9a:51:14:20:dd:4d:39:c8:05:6d:d5:6c:f8:0c:45:47:70:50:56:f5:bb:a5:9b:20:fd:49:e0:6c:a4:1a:dc:e1:d8:da:1c:e7:e5:ca:5f:62:21:4b:18:69:f2:5f:2d:26:9e:5f:74:bb:da:fc:82:b8:1c:8c:32:94:67:45:91:f3:ee:4c:62:db:68:48:00:43:fd:6f:ed:d2:98:dd:1b:34:24:96:c4:c9:c2:0c:e8:55:38:b1:12:a9:b1:3c:a0:0c:c3:ac:0c:c9:72:7a:63:76:72:08:bc:70:d7:34:65:f9:23:32:07:3b:4e:11:1c:25:21:96:16:14:f4:e7:98:2b:a6:44:b4:7e:7e:b5:ca:21:c3:66:a5:57:2c:5c:a1:e5:9a:a5:06:43:9c:af:f6:96:5a:37:ff:23:63:33:2b:b3:5b:62:f5:4e [P] WPS Manufacturer: Broadcom [P] WPS Model Name: Broadcom [P] WPS Model Number: 123456 [P] Access Point Serial Number: 1234 [Pin Gen] Zyxel Default Pin Generator [Pin Gen] Pin Generated : 42282457 [Pin Gen] Pin Generated (+1): 42282464 [Pin Gen] Pin Generated (-1): 42282440
Although it will be better to generate the PIN before than after... didn't see that ... but that's a another issue: The function works and the PIN is correctly generated.

But you're absolutely right: It would be better to have a better written code and i have exactly the same warning as you with our without the fix.
For me neither it didn't fixed this warnings and this issue should remain opened to "not forget about it"

from reaver-wps-fork-t6x.

kcdtv avatar kcdtv commented on August 16, 2024

This issue is about the same than this one; "Compile warning" #36
I close the other one and we keep this one open: There is no o need to have two issues about theses warnings.

from reaver-wps-fork-t6x.

kcdtv avatar kcdtv commented on August 16, 2024

Some patches proposed in issue "fix -n argument" are actually related to this issue.
This are the patches:
18e86f4
cd1af21
6b39995
da955d6

I tried to install the last commit of vk496 and compilation was perfectly clean (no error message) 👍

from reaver-wps-fork-t6x.

kcdtv avatar kcdtv commented on August 16, 2024

As long as the patches are not introduced let's keep it open
sorry for the time it takes but ... we have a life 😾
But be sure that soon we will merge the adequate patches to fix the issues (which is not an issue, just bullshit without importance to have a compilation without warning)
cheers.

from reaver-wps-fork-t6x.

blshkv avatar blshkv commented on August 16, 2024

tested the latest commit 86a45b5:

NOT fixed in master:

 * QA Notice: Package triggers severe warnings which indicate that it
 *            may exhibit random runtime failures.
 * common.c:614:5: warning: implicit declaration of function ‘wps_pin_checksum’ [-Wimplicit-function-declaration]
 * md5-internal.c:185:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
 * md5-internal.c:186:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
 * md5-internal.c:191:29: warning: argument to ‘sizeof’ in ‘memset’ call is the same expression as the destination; did you mean to dereference it? [-Wsizeof-pointer-memaccess]
 * wps_dev_attr.c:344:3: warning: implicit declaration of function ‘mac2str’ [-Wimplicit-function-declaration]
 * wps_dev_attr.c:364:3: warning: implicit declaration of function ‘pingen_zyxel’ [-Wimplicit-function-declaration]

from reaver-wps-fork-t6x.

soxrok2212 avatar soxrok2212 commented on August 16, 2024

Are you sure you pulled the latest commit? We had 3 people test (one of which being myself, running Debian 8) and had zero issues.

from reaver-wps-fork-t6x.

blshkv avatar blshkv commented on August 16, 2024

yes, pretty sure:

ebuild reaver-wps-fork-t6x-1.5.2_p20160909.ebuild compile 
>>> Unpacking source...
 * Fetching https://github.com/t6x/reaver-wps-fork-t6x.git ...
git fetch https://github.com/t6x/reaver-wps-fork-t6x.git +HEAD:refs/git-r3/HEAD
git update-ref --no-deref refs/git-r3/net-wireless/reaver-wps-fork-t6x/0/__main__ 86a45b5076b0100875de322ec0038337b13bfabc
 * Checking out https://github.com/t6x/reaver-wps-fork-t6x.git to /var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/work/reaver-wps-fork-t6x-1.5.2_p20160909 ...
git checkout --quiet 86a45b5076b0100875de322ec0038337b13bfabc
GIT update -->
   repository:               https://github.com/t6x/reaver-wps-fork-t6x.git
   at the commit:            86a45b5076b0100875de322ec0038337b13bfabc
>>> Source unpacked in /var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/work
>>> Preparing source in /var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/work/reaver-wps-fork-t6x-1.5.2_p20160909 ...
 * Running elibtoolize in: reaver-wps-fork-t6x-1.5.2_p20160909/src/
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/work/reaver-wps-fork-t6x-1.5.2_p20160909 ...
>>> Working in BUILD_DIR: "/var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/work/reaver-wps-fork-t6x-1.5.2_p20160909/src"
/var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/work/reaver-wps-fork-t6x-1.5.2_p20160909/src/configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --libdir=/usr/lib64 --docdir=/usr/share/doc/reaver-wps-fork-t6x-1.5.2_p20160909
checking for x86_64-pc-linux-gnu-gcc... x86_64-pc-linux-gnu-gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether x86_64-pc-linux-gnu-gcc accepts -g... yes
checking for x86_64-pc-linux-gnu-gcc option to accept ISO C89... none needed
checking for pcap_open_live in -lpcap... yes
checking for sqlite3_open in -lsqlite3... yes
checking how to run the C preprocessor... x86_64-pc-linux-gnu-gcc -E
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for stdlib.h... (cached) yes
checking for stdint.h... (cached) yes
checking for string.h... (cached) yes
checking pcap.h usability... yes
checking pcap.h presence... yes
checking for pcap.h... yes
checking sqlite3.h usability... yes
checking sqlite3.h presence... yes
checking for sqlite3.h... yes
configure: creating ./config.status
config.status: creating Makefile
>>> Source configured.
>>> Compiling source in /var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/work/reaver-wps-fork-t6x-1.5.2_p20160909 ...
>>> Working in BUILD_DIR: "/var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/work/reaver-wps-fork-t6x-1.5.2_p20160909/src"
make -j4 
(cd utils && make)
(cd tls && make)
(cd lwe && make BUILD_STATIC=y libiw.a)
(cd libwps && make)
make[1]: Entering directory '/var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/work/reaver-wps-fork-t6x-1.5.2_p20160909/src/lwe'
make[1]: Entering directory '/var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/work/reaver-wps-fork-t6x-1.5.2_p20160909/src/tls'
make[1]: Entering directory '/var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/work/reaver-wps-fork-t6x-1.5.2_p20160909/src/utils'
make[1]: Entering directory '/var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/work/reaver-wps-fork-t6x-1.5.2_p20160909/src/libwps'
gcc -Wall libwps.c -c
cp wireless.21.h wireless.h
gcc -Os -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Wpointer-arith -Wcast-qual -Winline -I. -MMD     -fPIC -c -o iwlib.so iwlib.c
libwps.c: In function ‘parse_wps_parameters’:
libwps.c:29:12: warning: variable ‘data_len’ set but not used [-Wunused-but-set-variable]
     size_t data_len = 0, offset = 0;
            ^
make[1]: Leaving directory '/var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/work/reaver-wps-fork-t6x-1.5.2_p20160909/src/libwps'
x86_64-pc-linux-gnu-gcc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe globule.c -c 
  CC  base64.c
iwlib.c: In function ‘iw_enum_devices’:
iwlib.c:254:9: warning: ignoring return value of ‘fgets’, declared with attribute warn_unused_result [-Wunused-result]
         fgets(buff, sizeof(buff), fh);
         ^
iwlib.c:255:9: warning: ignoring return value of ‘fgets’, declared with attribute warn_unused_result [-Wunused-result]
         fgets(buff, sizeof(buff), fh);
         ^
iwlib.c: In function ‘iw_get_kernel_we_version’:
iwlib.c:337:5: warning: ignoring return value of ‘fgets’, declared with attribute warn_unused_result [-Wunused-result]
     fgets(buff, sizeof(buff), fh);
     ^
iwlib.c:353:5: warning: ignoring return value of ‘fgets’, declared with attribute warn_unused_result [-Wunused-result]
     fgets(buff, sizeof(buff), fh);
     ^
  CC  asn1.c
common.c: In function ‘pingen_zhaochunsheng’:
common.c:597:14: warning: passing argument 1 of ‘snprintf’ makes pointer from integer without a cast
     snprintf(pin, pin_len, "%08d", (default_pin * 10) + wps_checksum(default_pin));
              ^
In file included from /usr/include/features.h:365:0,
                 from /usr/include/stdlib.h:24,
                 from includes.h:25,
                 from common.c:15:
/usr/include/bits/stdio2.h:61:1: note: expected ‘char * __restrict__’ but argument is of type ‘int’
 __NTH (snprintf (char *__restrict __s, size_t __n,
 ^
common.c: In function ‘pingen_zyxel’:
common.c:614:5: warning: implicit declaration of function ‘wps_pin_checksum’ [-Wimplicit-function-declaration]
     return (pin * 10) + wps_pin_checksum(pin);
     ^
In file included from bignum.c:21:0:
libtommath.c: In function ‘mp_exptmod’:
libtommath.c:580:9: warning: variable ‘dr’ set but not used [-Wunused-but-set-variable]
     int dr;
         ^
  CC  common.c
  CC  ip_addr.c
  CC  radiotap.c
x86_64-pc-linux-gnu-gcc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe init.c -c
  CC  trace.c
x86_64-pc-linux-gnu-gcc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe misc.c -c
rm -f libiw.a
ar cru libiw.a iwlib.so
ranlib libiw.a
make[1]: Leaving directory '/var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/work/reaver-wps-fork-t6x-1.5.2_p20160909/src/lwe'
x86_64-pc-linux-gnu-gcc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe -Ilibwps sql.c -c
  CC  uuid.c
x86_64-pc-linux-gnu-gcc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe builder.c -c
  CC  bignum.c
  CC  wpa_debug.c
x86_64-pc-linux-gnu-gcc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe crc.c -c
x86_64-pc-linux-gnu-gcc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe iface.c -c
x86_64-pc-linux-gnu-gcc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe -Ilibwps sigint.c -c
  CC  pkcs1.c
  CC  wpabuf.c
x86_64-pc-linux-gnu-gcc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe sigalrm.c -c
x86_64-pc-linux-gnu-gcc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe keys.c -c
  CC  pkcs5.c
x86_64-pc-linux-gnu-gcc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe -Ilibwps session.c -c
  CC  os_unix.c
  CC  pkcs8.c
x86_64-pc-linux-gnu-gcc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe -Ilibwps argsparser.c -c
  CC  rsa.c
  CC  eloop.c
ar crT libutils.a base64.o common.o ip_addr.o radiotap.o trace.o uuid.o wpa_debug.o wpabuf.o os_unix.o eloop.o
make[1]: Leaving directory '/var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/work/reaver-wps-fork-t6x-1.5.2_p20160909/src/utils'
x86_64-pc-linux-gnu-gcc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe -Ilibwps 80211.c -c
x86_64-pc-linux-gnu-gcc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe pins.c -c
x86_64-pc-linux-gnu-gcc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe send.c -c
  CC  tlsv1_client.c
  CC  tlsv1_client_read.c
  CC  tlsv1_common.c
  CC  tlsv1_client_write.c
  CC  tlsv1_cred.c
x86_64-pc-linux-gnu-gcc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe -Ilibwps exchange.c -c
tlsv1_server_read.c: In function ‘tls_process_client_key_exchange_rsa’:
  CC  tlsv1_record.c
tlsv1_server_read.c:474:9: warning: variable ‘encr_len’ set but not used [-Wunused-but-set-variable]
     u16 encr_len;
         ^
  CC  tlsv1_server.c
x86_64-pc-linux-gnu-gcc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe -Ilibwps cracker.c -c
  CC  tlsv1_server_write.c
  CC  tlsv1_server_read.c
  CC  x509v3.c
ar crT libtls.a asn1.o bignum.o pkcs1.o pkcs5.o pkcs8.o rsa.o tlsv1_client.o tlsv1_client_read.o tlsv1_client_write.o tlsv1_common.o tlsv1_cred.o tlsv1_record.o tlsv1_server.o tlsv1_server_read.o tlsv1_server_write.o x509v3.o
make[1]: Leaving directory '/var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/work/reaver-wps-fork-t6x-1.5.2_p20160909/src/tls'
(cd crypto && make)
make[1]: Entering directory '/var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/work/reaver-wps-fork-t6x-1.5.2_p20160909/src/crypto'
  CC  aes-ctr.c
  CC  aes-cbc.c
  CC  aes-encblock.c
  CC  aes-eax.c
  CC  aes-internal.c
  CC  aes-omac1.c
  CC  aes-unwrap.c
  CC  aes-internal-enc.c
  CC  aes-internal-dec.c
  CC  aes-wrap.c
  CC  dh_group5.c
  CC  dh_groups.c
md5-internal.c: In function ‘MD5Final’:
md5-internal.c:185:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
     ((u32 *) ctx->in)[14] = ctx->bits[0];
     ^
md5-internal.c:186:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
     ((u32 *) ctx->in)[15] = ctx->bits[1];
     ^
In file included from ../utils/common.h:18:0,
                 from md5-internal.c:17:
md5-internal.c:191:29: warning: argument to ‘sizeof’ in ‘memset’ call is the same expression as the destination; did you mean to dereference it? [-Wsizeof-pointer-memaccess]
     os_memset(ctx, 0, sizeof(ctx)); /* In case it's sensitive */
                             ^
../utils/os.h:413:41: note: in definition of macro ‘os_memset’
 #define os_memset(s, c, n) memset(s, c, n)
                                         ^
  CC  md5.c
  CC  des-internal.c
  CC  md4-internal.c
  CC  md5-non-fips.c
  CC  md5-internal.c
  CC  milenage.c
  CC  rc4.c
  CC  sha1.c
  CC  ms_funcs.c
  CC  sha1-pbkdf2.c
  CC  sha1-tlsprf.c
  CC  sha1-tprf.c
  CC  sha256.c
  CC  sha256-internal.c
  CC  crypto_internal.c
  CC  crypto_internal-modexp.c
  CC  crypto_internal-rsa.c
  CC  crypto_internal-cipher.c
  CC  sha1-internal.c
  CC  fips_prf_internal.c
  CC  tls_internal.c
ar crT libcrypto.a aes-cbc.o aes-ctr.o aes-eax.o aes-encblock.o aes-internal.o aes-internal-dec.o aes-internal-enc.o aes-omac1.o aes-unwrap.o aes-wrap.o des-internal.o dh_group5.o dh_groups.o md4-internal.o md5.o md5-internal.o md5-non-fips.o milenage.o ms_funcs.o rc4.o sha1.o sha1-internal.o sha1-pbkdf2.o sha1-tlsprf.o sha1-tprf.o sha256.o sha256-internal.o crypto_internal.o crypto_internal-cipher.o crypto_internal-modexp.o crypto_internal-rsa.o tls_internal.o fips_prf_internal.o
make[1]: Leaving directory '/var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/work/reaver-wps-fork-t6x-1.5.2_p20160909/src/crypto'
(cd wps && make)
make[1]: Entering directory '/var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/work/reaver-wps-fork-t6x-1.5.2_p20160909/src/wps'
cc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe -I../utils -I ../ wps_attr_build.c -c
cc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe -I../utils -I ../ wps_attr_parse.c -c
cc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe -I../utils -I ../ wps_attr_process.c -c
cc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe -I../utils -I ../ wps.c -c
cc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe -I../utils -I ../ wps_common.c -c
cc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe -I../utils -I ../ wps_dev_attr.c -c
cc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe -I../utils -I ../ wps_enrollee.c -c
wps_dev_attr.c: In function ‘wps_process_manufacturer’:
wps_dev_attr.c:200:26: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
             printf("%c", (char *) str[pixiecnt]);
                          ^
wps_dev_attr.c:200:13: warning: format ‘%c’ expects argument of type ‘int’, but argument 2 has type ‘char *’ [-Wformat=]
             printf("%c", (char *) str[pixiecnt]);
             ^
wps_dev_attr.c: In function ‘wps_process_model_name’:
wps_dev_attr.c:241:26: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
             printf("%c", (char *) str[pixiecnt]);
                          ^
wps_dev_attr.c:241:13: warning: format ‘%c’ expects argument of type ‘int’, but argument 2 has type ‘char *’ [-Wformat=]
             printf("%c", (char *) str[pixiecnt]);
             ^
wps_dev_attr.c: In function ‘wps_process_model_number’:
wps_dev_attr.c:280:26: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
             printf("%c", (char *) str[pixiecnt]);
                          ^
wps_dev_attr.c:280:13: warning: format ‘%c’ expects argument of type ‘int’, but argument 2 has type ‘char *’ [-Wformat=]
             printf("%c", (char *) str[pixiecnt]);
             ^
wps_dev_attr.c: In function ‘wps_process_serial_number’:
wps_dev_attr.c:319:26: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
             printf("%c", (char *) str[pixiecnt]);
                          ^
wps_dev_attr.c:319:13: warning: format ‘%c’ expects argument of type ‘int’, but argument 2 has type ‘char *’ [-Wformat=]
             printf("%c", (char *) str[pixiecnt]);
             ^
wps_dev_attr.c:344:3: warning: implicit declaration of function ‘mac2str’ [-Wimplicit-function-declaration]
   printf("[Pin Gen] Pin Generated : %08d\n",pingen_belkin(mac2str(get_bssid(),'\0'), str, str_len, 0));
   ^
wps_dev_attr.c:344:59: warning: passing argument 1 of ‘pingen_belkin’ makes pointer from integer without a cast
   printf("[Pin Gen] Pin Generated : %08d\n",pingen_belkin(mac2str(get_bssid(),'\0'), str, str_len, 0));
                                                           ^
In file included from ../wps.h:40:0,
                 from ../defs.h:46,
                 from ../globule.h:38,
                 from wps_dev_attr.c:15:
../utils/common.h:447:5: note: expected ‘char *’ but argument is of type ‘int’
 int pingen_belkin(char *mac, char *serial, int len_serial, int add); 
     ^
wps_dev_attr.c:344:86: warning: passing argument 2 of ‘pingen_belkin’ discards ‘const’ qualifier from pointer target type
   printf("[Pin Gen] Pin Generated : %08d\n",pingen_belkin(mac2str(get_bssid(),'\0'), str, str_len, 0));
                                                                                      ^
In file included from ../wps.h:40:0,
                 from ../defs.h:46,
                 from ../globule.h:38,
                 from wps_dev_attr.c:15:
../utils/common.h:447:5: note: expected ‘char *’ but argument is of type ‘const u8 *’
 int pingen_belkin(char *mac, char *serial, int len_serial, int add); 
     ^
wps_dev_attr.c:345:63: warning: passing argument 1 of ‘pingen_belkin’ makes pointer from integer without a cast
   printf("[Pin Gen] Pin Generated (+1): %08d\n",pingen_belkin(mac2str(get_bssid(),'\0'), str, str_len, 1));
                                                               ^
In file included from ../wps.h:40:0,
                 from ../defs.h:46,
                 from ../globule.h:38,
                 from wps_dev_attr.c:15:
../utils/common.h:447:5: note: expected ‘char *’ but argument is of type ‘int’
 int pingen_belkin(char *mac, char *serial, int len_serial, int add); 
     ^
wps_dev_attr.c:345:90: warning: passing argument 2 of ‘pingen_belkin’ discards ‘const’ qualifier from pointer target type
   printf("[Pin Gen] Pin Generated (+1): %08d\n",pingen_belkin(mac2str(get_bssid(),'\0'), str, str_len, 1));
                                                                                          ^
In file included from ../wps.h:40:0,
                 from ../defs.h:46,
                 from ../globule.h:38,
                 from wps_dev_attr.c:15:
../utils/common.h:447:5: note: expected ‘char *’ but argument is of type ‘const u8 *’
 int pingen_belkin(char *mac, char *serial, int len_serial, int add); 
     ^
wps_dev_attr.c:346:65: warning: passing argument 1 of ‘pingen_belkin’ makes pointer from integer without a cast
   printf("[Pin Gen] Pin Generated (-1): %08d\n\n",pingen_belkin(mac2str(get_bssid(),'\0'), str, str_len, -1));
                                                                 ^
In file included from ../wps.h:40:0,
                 from ../defs.h:46,
                 from ../globule.h:38,
                 from wps_dev_attr.c:15:
../utils/common.h:447:5: note: expected ‘char *’ but argument is of type ‘int’
 int pingen_belkin(char *mac, char *serial, int len_serial, int add); 
     ^
wps_dev_attr.c:346:92: warning: passing argument 2 of ‘pingen_belkin’ discards ‘const’ qualifier from pointer target type
   printf("[Pin Gen] Pin Generated (-1): %08d\n\n",pingen_belkin(mac2str(get_bssid(),'\0'), str, str_len, -1));
                                                                                            ^
In file included from ../wps.h:40:0,
                 from ../defs.h:46,
                 from ../globule.h:38,
                 from wps_dev_attr.c:15:
../utils/common.h:447:5: note: expected ‘char *’ but argument is of type ‘const u8 *’
 int pingen_belkin(char *mac, char *serial, int len_serial, int add); 
     ^
wps_dev_attr.c:355:58: warning: passing argument 1 of ‘pingen_dlink’ makes pointer from integer without a cast
   printf("[Pin Gen] Pin Generated : %08d\n",pingen_dlink(mac2str(get_bssid(),'\0'), 0));
                                                          ^
In file included from ../wps.h:40:0,
                 from ../defs.h:46,
                 from ../globule.h:38,
                 from wps_dev_attr.c:15:
../utils/common.h:448:5: note: expected ‘char *’ but argument is of type ‘int’
 int pingen_dlink(char *mac, int add);        
     ^
wps_dev_attr.c:356:62: warning: passing argument 1 of ‘pingen_dlink’ makes pointer from integer without a cast
   printf("[Pin Gen] Pin Generated (+1): %08d\n",pingen_dlink(mac2str(get_bssid(),'\0'), 1));
                                                              ^
In file included from ../wps.h:40:0,
                 from ../defs.h:46,
                 from ../globule.h:38,
                 from wps_dev_attr.c:15:
../utils/common.h:448:5: note: expected ‘char *’ but argument is of type ‘int’
 int pingen_dlink(char *mac, int add);        
     ^
wps_dev_attr.c:357:64: warning: passing argument 1 of ‘pingen_dlink’ makes pointer from integer without a cast
   printf("[Pin Gen] Pin Generated (-1): %08d\n\n",pingen_dlink(mac2str(get_bssid(),'\0'), -1));
                                                                ^
In file included from ../wps.h:40:0,
                 from ../defs.h:46,
                 from ../globule.h:38,
                 from wps_dev_attr.c:15:
../utils/common.h:448:5: note: expected ‘char *’ but argument is of type ‘int’
 int pingen_dlink(char *mac, int add);        
     ^
wps_dev_attr.c:364:3: warning: implicit declaration of function ‘pingen_zyxel’ [-Wimplicit-function-declaration]
   printf("[Pin Gen] Pin Generated : %08d\n",pingen_zyxel(mac2str(get_bssid(),'\0'), 0));
   ^
cc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe -I../utils -I ../ wps_registrar.c -c
cc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe -I../utils -I ../ wps_ufd.c -c
wps_registrar.c: In function ‘wps_build_m4’:
wps_registrar.c:1499:5: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘size_t’ [-Wformat=]
     wpa_printf(MSG_DEBUG, "WPS: Dev Password Len: %d", wps->dev_password_len);
     ^
In file included from /usr/include/string.h:630:0,
                 from ../defs.h:42,
                 from ../globule.h:38,
                 from wps_registrar.c:14:
wps_registrar.c: In function ‘wps_process_ap_settings_r’:
wps_registrar.c:2791:27: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign]
         wps->key = strdup(wps->cred.key);
                           ^
In file included from ../defs.h:42:0,
                 from ../globule.h:38,
                 from wps_registrar.c:14:
/usr/include/string.h:394:15: note: expected ‘const char *’ but argument is of type ‘u8 *’
 extern size_t strlen (const char *__s)
               ^
In file included from /usr/include/string.h:630:0,
                 from ../defs.h:42,
                 from ../globule.h:38,
                 from wps_registrar.c:14:
wps_registrar.c:2791:27: warning: pointer targets in passing argument 1 of ‘__strdup’ differ in signedness [-Wpointer-sign]
         wps->key = strdup(wps->cred.key);
                           ^
/usr/include/bits/string2.h:1278:14: note: expected ‘const char *’ but argument is of type ‘u8 *’
 extern char *__strdup (const char *__string) __THROW __attribute_malloc__;
              ^
wps_registrar.c:2795:29: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign]
         wps->essid = strdup(wps->cred.ssid);
                             ^
In file included from ../defs.h:42:0,
                 from ../globule.h:38,
                 from wps_registrar.c:14:
/usr/include/string.h:394:15: note: expected ‘const char *’ but argument is of type ‘u8 *’
 extern size_t strlen (const char *__s)
               ^
In file included from /usr/include/string.h:630:0,
                 from ../defs.h:42,
                 from ../globule.h:38,
                 from wps_registrar.c:14:
wps_registrar.c:2795:29: warning: pointer targets in passing argument 1 of ‘__strdup’ differ in signedness [-Wpointer-sign]
         wps->essid = strdup(wps->cred.ssid);
                             ^
/usr/include/bits/string2.h:1278:14: note: expected ‘const char *’ but argument is of type ‘u8 *’
 extern char *__strdup (const char *__string) __THROW __attribute_malloc__;
              ^
wps_registrar.c: At top level:
wps_registrar.c:257:13: warning: ‘wps_registrar_remove_pbc_session’ defined but not used [-Wunused-function]
 static void wps_registrar_remove_pbc_session(struct wps_registrar *reg,
             ^
wps_registrar.c:759:13: warning: ‘wps_registrar_pbc_completed’ defined but not used [-Wunused-function]
 static void wps_registrar_pbc_completed(struct wps_registrar *reg)
             ^
wps_registrar.c:770:13: warning: ‘wps_registrar_pin_completed’ defined but not used [-Wunused-function]
 static void wps_registrar_pin_completed(struct wps_registrar *reg)
             ^
wps_registrar.c:862:12: warning: ‘wps_cb_new_psk’ defined but not used [-Wunused-function]
 static int wps_cb_new_psk(struct wps_registrar *reg, const u8 *mac_addr,
            ^
wps_registrar.c:888:13: warning: ‘wps_cb_reg_success’ defined but not used [-Wunused-function]
 static void wps_cb_reg_success(struct wps_registrar *reg, const u8 *mac_addr,
             ^
wps_registrar.c:1456:24: warning: ‘wps_build_m2d’ defined but not used [-Wunused-function]
 static struct wpabuf * wps_build_m2d(struct wps_data *wps)
                        ^
wps_registrar.c:2252:12: warning: ‘wps_process_e_snonce2’ defined but not used [-Wunused-function]
 static int wps_process_e_snonce2(struct wps_data *wps, const u8 *e_snonce2)
            ^
make[1]: Leaving directory '/var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/work/reaver-wps-fork-t6x-1.5.2_p20160909/src/wps'
x86_64-pc-linux-gnu-gcc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe -Ilibwps wpsmon.c *.o libwps/*.o wps/*.o tls/bignum.o tls/libtls.a utils/libutils.a crypto/libcrypto.a lwe/libiw.a -ldl -lm -lpcap -lsqlite3 -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -o wash
x86_64-pc-linux-gnu-gcc -DCONF_DIR='"/etc/reaver"' -DREAVER_DATABASE='"/etc/reaver/reaver.db"' -Wall -march=native -O2 -pipe -Ilibwps wpscrack.c *.o libwps/*.o wps/*.o tls/bignum.o tls/libtls.a utils/libutils.a crypto/libcrypto.a lwe/libiw.a -ldl -lm -lpcap -lsqlite3 -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -o reaver
wpscrack.c: In function ‘main’:
wpscrack.c:134:13: warning: ignoring return value of ‘system’, declared with attribute warn_unused_result [-Wunused-result]
             system(get_exec_string());
             ^
>>> Source compiled.
sudo ebuild reaver-wps-fork-t6x-1.5.2_p20160909.ebuild install 
>>> Existing ${T}/environment for 'reaver-wps-fork-t6x-1.5.2_p20160909'
>>> will be sourced. Run 'clean' to start with a fresh environment.
>>> WORKDIR is up-to-date, keeping...
>>> It appears that 'pretend' has already executed for 'reaver-wps-fork-t6x-1.5.2_p20160909'; skipping.
>>> Remove '/var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/.pretended' to force pretend.
>>> It appears that 'setup' has already executed for 'reaver-wps-fork-t6x-1.5.2_p20160909'; skipping.
>>> Remove '/var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/.setuped' to force setup.
>>> It appears that 'unpack' has already executed for 'reaver-wps-fork-t6x-1.5.2_p20160909'; skipping.
>>> Remove '/var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/.unpacked' to force unpack.
>>> It appears that 'prepare' has already executed for 'reaver-wps-fork-t6x-1.5.2_p20160909'; skipping.
>>> Remove '/var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/.prepared' to force prepare.
>>> It appears that 'configure' has already executed for 'reaver-wps-fork-t6x-1.5.2_p20160909'; skipping.
>>> Remove '/var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/.configured' to force configure.
>>> It appears that 'compile' has already executed for 'reaver-wps-fork-t6x-1.5.2_p20160909'; skipping.
>>> Remove '/var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/.compiled' to force compile.
>>> Test phase [not enabled]: net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909
chgrp: changing group of ‘/var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/temp/environment’: Operation not permitted
chmod: changing permissions of ‘/var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/temp/environment’: Operation not permitted

>>> Install reaver-wps-fork-t6x-1.5.2_p20160909 into /var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/image/ category net-wireless
>>> Completed installing reaver-wps-fork-t6x-1.5.2_p20160909 into /var/tmp/portage/net-wireless/reaver-wps-fork-t6x-1.5.2_p20160909/image/

 * Final size of build directory: 7084 KiB
 * Final size of installed tree: 1536 KiB


 * QA Notice: Package triggers severe warnings which indicate that it
 *            may exhibit random runtime failures.
 * common.c:614:5: warning: implicit declaration of function ‘wps_pin_checksum’ [-Wimplicit-function-declaration]
 * md5-internal.c:185:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
 * md5-internal.c:186:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
 * md5-internal.c:191:29: warning: argument to ‘sizeof’ in ‘memset’ call is the same expression as the destination; did you mean to dereference it? [-Wsizeof-pointer-memaccess]
 * wps_dev_attr.c:344:3: warning: implicit declaration of function ‘mac2str’ [-Wimplicit-function-declaration]
 * wps_dev_attr.c:364:3: warning: implicit declaration of function ‘pingen_zyxel’ [-Wimplicit-function-declaration]

 * Please do not file a Gentoo bug and instead report the above QA
 * issues directly to the upstream developers of this software.
 * Homepage: https://github.com/t6x/reaver-wps-fork-t6x
strip: x86_64-pc-linux-gnu-strip --strip-unneeded -R .comment -R .GCC.command.line -R .note.gnu.gold-version
   usr/bin/wash
   usr/bin/reaver
ecompressdir: bzip2 -9 /usr/share/man
ecompressdir: bzip2 -9 /usr/share/doc

from reaver-wps-fork-t6x.

blshkv avatar blshkv commented on August 16, 2024

Please re-open the bug report ;-)

from reaver-wps-fork-t6x.

kcdtv avatar kcdtv commented on August 16, 2024

which system do you use?
Are you sure that you did not use the same makefile?
i just tryed and it is Perfectly working in kali 2016.1 & 2016.2
i'll try tonight in xubuntu...
weird....

from reaver-wps-fork-t6x.

ZeroChaos- avatar ZeroChaos- commented on August 16, 2024

⚠ advisory
Post entirely removed for being off-topic and nonconstructive
This is not a query center and lacks of respect will not be tolerated any longer here

Sincerely your, kcdtv

from reaver-wps-fork-t6x.

kcdtv avatar kcdtv commented on August 16, 2024
  • With kali 2016.x: no warning ( i tryed several time)
  • With debian 8: no warning (soxrock tried)
  • With Xubuntu 16.04 : one warning (at the end, function wpscrack, i just tryed)
  • With slackware: no warning (fixed made by vk496 under this system)
    this is the only fail i get, under ubuntu

kcdtv@Andtoid4S1M0V:~/reaver-wps-fork-t6x.git/trunk/src$ make
(cd utils && make)
make[1] : on entre dans le répertoire « /home/kcdtv/reaver-wps-fork-t6x.git/trunk/src/utils »
make[1]: rien à faire pour « all ».
make[1] : on quitte le répertoire « /home/kcdtv/reaver-wps-fork-t6x.git/trunk/src/utils »
(cd tls && make)
make[1] : on entre dans le répertoire « /home/kcdtv/reaver-wps-fork-t6x.git/trunk/src/tls »
make[1]: rien à faire pour « all ».
make[1] : on quitte le répertoire « /home/kcdtv/reaver-wps-fork-t6x.git/trunk/src/tls »
(cd crypto && make)
make[1] : on entre dans le répertoire « /home/kcdtv/reaver-wps-fork-t6x.git/trunk/src/crypto »
make[1]: rien à faire pour « all ».
make[1] : on quitte le répertoire « /home/kcdtv/reaver-wps-fork-t6x.git/trunk/src/crypto »
(cd wps && make)
make[1] : on entre dans le répertoire « /home/kcdtv/reaver-wps-fork-t6x.git/trunk/src/wps »
make[1]: rien à faire pour « all ».
make[1] : on quitte le répertoire « /home/kcdtv/reaver-wps-fork-t6x.git/trunk/src/wps »
(cd lwe && make BUILD_STATIC=y libiw.a)
make[1] : on entre dans le répertoire « /home/kcdtv/reaver-wps-fork-t6x.git/trunk/src/lwe »
make[1]: « libiw.a » est à jour.
make[1] : on quitte le répertoire « /home/kcdtv/reaver-wps-fork-t6x.git/trunk/src/lwe »
(cd libwps && make)
make[1] : on entre dans le répertoire « /home/kcdtv/reaver-wps-fork-t6x.git/trunk/src/libwps »
make[1]: « libwps.o » est à jour.
make[1] : on quitte le répertoire « /home/kcdtv/reaver-wps-fork-t6x.git/trunk/src/libwps »
gcc -DCONF_DIR='"/usr/local/etc/reaver"' -DREAVER_DATABASE='"/usr/local/etc/reaver/reaver.db"' -Wall -g -O2 -Ilibwps wpsmon.c .o libwps/.o wps/.o tls/bignum.o tls/libtls.a utils/libutils.a crypto/libcrypto.a lwe/libiw.a -ldl -lm -lpcap -lsqlite3 -o wash
gcc -DCONF_DIR='"/usr/local/etc/reaver"' -DREAVER_DATABASE='"/usr/local/etc/reaver/reaver.db"' -Wall -g -O2 -Ilibwps wpscrack.c *.o libwps/
.o wps/*.o tls/bignum.o tls/libtls.a utils/libutils.a crypto/libcrypto.a lwe/libiw.a -ldl -lm -lpcap -lsqlite3 -o reaver
wpscrack.c: In function ‘main’:
wpscrack.c:134:13: warning: ignoring return value of ‘system’, declared with attribute warn_unused_result [-Wunused-result]
system(get_exec_string());
^

it seems that blshkv use a distribution called "pentoo" which might be based on gentoo
So the situation is:

  1. reaver always had this warning.
  2. Since this commit warning are solved for debian, kali, salckware and nearly solved for Ubuntu
  3. For pentoo/gentoo: no change (or worst, can't tell, never tried)

Remember that reaver mod is first of all designed for kali linux which is a debian SID based system
Bringing support to ubuntu and linux mint or other derivative from debian can be pretty straight forward and easy
We for sure would be happy to introduce any modification that can fix this issues (as long at it does not break kali linux/debian compilation) in gentoo and derivatives
Remember that this is not a critical issue: Install reaver and you will see that it installs and works properly
Cheers

from reaver-wps-fork-t6x.

blshkv avatar blshkv commented on August 16, 2024

Yes, I'm developer of Pentoo Linux. But you are missing the point because It's not about linux distribution. The main difference is that we use hardened linux and more strict GCC parameters by default. It allows us to identify such problem on compilation (earlier) stage.

It is obvious from my log if you try try to read it. For example:

gcc -Os -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Wpointer-arith -Wcast-qual -Winline -I. -MMD     -fPIC -c -o iwlib.so iwlib.c

Update: also see:
https://dev.gentoo.org/~zmedico/portage/doc/ch07s10.html

Historically, these warnings did not show up as the optimization was not turned on by default. With gcc-4.1.x and newer though, the -O2 optimization level enables strict aliasing support.

Our current gcc settings are below:

gcc -v
Using built-in specs.
COLLECT_GCC=/usr/x86_64-pc-linux-gnu/gcc-bin/4.9.3/gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-pc-linux-gnu/4.9.3/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /var/tmp/notmpfs/portage/sys-devel/gcc-4.9.3/work/gcc-4.9.3/configure --host=x86_64-pc-linux-gnu --build=x86_64-pc-linux-gnu --prefix=/usr --bindir=/usr/x86_64-pc-linux-gnu/gcc-bin/4.9.3 --includedir=/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.3/include --datadir=/usr/share/gcc-data/x86_64-pc-linux-gnu/4.9.3 --mandir=/usr/share/gcc-data/x86_64-pc-linux-gnu/4.9.3/man --infodir=/usr/share/gcc-data/x86_64-pc-linux-gnu/4.9.3/info --with-gxx-include-dir=/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.3/include/g++-v4 --with-python-dir=/share/gcc-data/x86_64-pc-linux-gnu/4.9.3/python --enable-languages=c,c++,fortran --enable-obsolete --enable-secureplt --disable-werror --with-system-zlib --enable-nls --without-included-gettext --enable-checking=release --with-bugurl=https://bugs.gentoo.org/ --with-pkgversion='Gentoo Hardened 4.9.3 p1.5, pie-0.6.4' --enable-esp --enable-libstdcxx-time --enable-shared --enable-threads=posix --enable-__cxa_atexit --enable-clocale=gnu --enable-multilib --with-multilib-list=m32,m64 --disable-altivec --disable-fixed-point --enable-targets=all --disable-libgcj --enable-libgomp --disable-libmudflap --disable-libssp --disable-libcilkrts --disable-vtable-verify --disable-libvtv --enable-lto --without-cloog --disable-libsanitizer
Thread model: posix
gcc version 4.9.3 (Gentoo Hardened 4.9.3 p1.5, pie-0.6.4)

from reaver-wps-fork-t6x.

kcdtv avatar kcdtv commented on August 16, 2024

Hi blshkv
When I said that "the linux distribution" it was a "shortcut" to speak about the packages/elements that composes your Operative System
And I was actually thinking that it was coming from gcc ... For one time that I was not equivocated, please don't take that away form me 😃
May i suggest to you next time, to clarify things since the beginning, that you should start by saying that you use a fork from gentoo instead of a supported distribution (debian bazed) ...
It would be good to bring much more elements when you report an issue: They actually don't charge you in github for making sentences or using words, you can be eloquent đŸ˜ș
About your gcc version.... upssssss... What can I say? ..
It is more than one year old and have known security issue https://www.cvedetails.com/cve/CVE-2015-5276/
Backward compatibility with an unsafe version is definitely not generally a priority in a project and perfect "retrocompatibility" is sadly unsustainable....
As I said: I don't know C, don't know the art of compiling, do not use a gentoo derivate, do not downgrade package to break my dependencies system so....

edit
I removed part of this post that was an answer to edited messages

from reaver-wps-fork-t6x.

blshkv avatar blshkv commented on August 16, 2024

So Pentoo is not a fork. It's an overlay, i.e. an extension of Gentoo. I. We use the latest stable gcc but open for any suggestions.
tell me which version of gcc should i try.

Also, you should try strict options of gcc as i suggested

⚠
This post has been partially edited for non polite / non respectful comments
Sincerely your, kcdtv

from reaver-wps-fork-t6x.

kcdtv avatar kcdtv commented on August 16, 2024

Sorry if i didn't answer before, i was very busy, no time for nothing

So Pentoo is not a fork. It's an overlay,

I don't know what is an "overlay" but saying fork was not pejorative in my mind.
Thanks for the precisions. 😉

Sincerely I don't know what you should do or what can be done for you,
From what I understood gcc 6.2 is the last stable release ( and not 4.9.3)
So maybe try with the last stable release.
Or at least with a more recent version
I can tell you that with version superior to the one you use in distribution such as ubutnu, kali, slackware and debian there is no problem (but i guess that you understood that, the "bullshit" part)
This is my stdout of gcc -v with kali (updated)
gcc -v Using built-in specs. COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/6/lto-wrapper Target: x86_64-linux-gnu Configured with: ../src/configure -v --with-pkgversion='Debian 6.1.1-11' --with-bugurl=file:///usr/share/doc/gcc-6/README.Bugs --enable-languages=c,ada,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-6 --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-libmpx --enable-plugin --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-6-amd64/jre --enable-java-home --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-6-amd64 --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-6-amd64 --with-arch-directory=amd64 --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-objc-gc --enable-multiarch --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu Thread model: posix gcc version 6.1.1 20160802 (Debian 6.1.1-11)

Also, you should try strict options of gcc as i suggested

I don't know how to do that
I use the gcc provided by the repositories of the distributions I use as they provide it, no modification, no changes.
It is 64bits with multiarch etc... i can post you the stdout of gcc in ubuntu if you want
Sorry if that doesn't help you a lot, I really can't tell you more...
We for sure will keep this issue open as long as needed for a better compatibility with pentoo in order to satisfy your request.
Take care.

from reaver-wps-fork-t6x.

blshkv avatar blshkv commented on August 16, 2024

so, again, it has nothing to do with pentoo or pentoo compatibility.
There are few security options in GCC which might not be enabled by default in your favorite distro. These options can detect various problems on the early stage (during compilation).

To enable them all, run the following (asking for the third time):

make clean
./configure
make -Wall

Make sure to scroll back and read the output. The latest GCC might have more checks and it might be more warnings

⚠ EDIT
Non constructive and disrespectful comments have been removed form this post
Sincerely your, kcdtv

from reaver-wps-fork-t6x.

kcdtv avatar kcdtv commented on August 16, 2024

To sum-up and clarify this messy situation

  1. You are right: Compiling with -W flag does actually provokes several warning and this regardless the version of gcc or the GNU-Linux distribution used, making the current patches from vk946 "useless".
  2. Nevertheless: Following the manual and compiling as it is recommended this warning does not show at all (just one in latest ubuntu - 16.04)which is a good step forward and to my sense legitimate that we maintain the patches of vk946 and do not revert them
  3. It is maybe good to remember that this warnings does not affect at all the good functioning of reaver and are kind of "cosmetic issue"... For example: an implicitly declared variable in the "pingen for zyxell" is not a concern at all any time

Take care and good luck with your projetcs.

edit
I removed part of my post which was an answer to previously removed comments

from reaver-wps-fork-t6x.

blshkv avatar blshkv commented on August 16, 2024
  1. some warnings are "cosmetic" while others are not. I have listed only "severe" ones which might cause memory corruption and lead to a crash or become a security issue.

from reaver-wps-fork-t6x.

kcdtv avatar kcdtv commented on August 16, 2024

This issue it is closed.
Warning related issues will be debated in other threads with constructive attitude.
No demands or arrogant behavior will be tolerated in this repository.
Thank you for your attention.

from reaver-wps-fork-t6x.

blshkv avatar blshkv commented on August 16, 2024

Absolutely agree. It is very difficult to bring to the point when all arguments hit non technical "debian only" wall attitude

from reaver-wps-fork-t6x.

kcdtv avatar kcdtv commented on August 16, 2024

Mmmmm
You sadly totally missed the point with your so original "debian only" blabla...
The problem is simply your behavior of arrogant spoiled children.
Good luck with that

from reaver-wps-fork-t6x.

blshkv avatar blshkv commented on August 16, 2024

Nop, I totally got it. But this is an arrogant behavior of technical guru talking to a wrong guy who doesn't even know C and trying to act as a protective PM. Come on, it's been two months since we settled all missunderstandings. Let it go, focus on the problem and fix it.

from reaver-wps-fork-t6x.

kcdtv avatar kcdtv commented on August 16, 2024

I didn't see that
Technical guru? LOL
Guru for script kiddies maybe....
i will do you a favour and lock this conversation because you are right now ridiculously arrogant
Ask to santa claus for some humility dude,
merry xmas,

from reaver-wps-fork-t6x.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.