Stuck on findOne about typegoose

[Christilut]

Nice work! Removing node_modules/typegoose/node_modules/mongoose fixed it for me (as a quick test).

And your above workaround works too.

[vinczedani]

Hi @valneras

You should pass your own mongoose instance in the getModelForClass method if you have any. The second parameter (options) has a property called existingMongoose. This should make the typegooses owned fallback mongoose unused, so the deprecation warning should disappear.

You can also pass in an existing mongoose connection if you have any. It can also passed down to typegoose in the getModelForClass methods second parameter. Under the existingConnection key in the options object.

The precedency of all the mongooses inside typegoose is the following:

1. existingConnection
2. existingMongoose
3. typegooses own mongoose

Unfortunately, we don't really have spare time for typegoose at the moment. In the future we plan to deprecate our own mongoose as a dependency and add it as a peer dependency instead. But since it is a breaking change for those who rely on the built in mongoose instance, it is more complicated to do, than just changing two lines in the package.json.
I hope this will fix your problem.

Cheers,
Daniel

[iamdanthedev]

This is a workaround, it prevents installing non-flat mongoose dependency

yarn remove typegoose mongoose
yarn add [email protected] typegoose

[vinczedani]

Hi @Christilut
We are aware of the issue that typegoose has its own mongoose version. It is on our todo list to list mongoose as a peer dependency instead of a normal one. It should resolve some issues.

The pre save is after the validation, but mongoose offers pre validation hook too. In your case, you should give it a try ;)

[Christilut]

Probably a mongoose issue but I really can't figure this one out.

Tried bluebird, older mongoose versions, lots of different settings but nothing seems to work.

[iamdanthedev]

Same story! If I switch to native mongoose schema way - everything works :-(

[iamdanthedev]

Tried to supply 'existingCollection' to models - doesn't help

[Christilut]

I'm using typegoose to create a boilerplate so anyone that wants to take look: here it is

Use the typegoose-hangs branch.

Copy .env.example to .env, (change MONGO_HOST if needed) run npm install, then npm run dev and it should work (I hope 😛)

This is the last I see:

saving new user for testing
pre save !!!
(node:1685) DeprecationWarning: Mongoose: mpromise (mongoose's default promise library) is deprecated, plug in your own promise library instead: http://mongoosejs.com/docs/promises.html

Check /node-api-boilerplate/server/models/user/model.ts for relevant model code and config/mongoose.ts for mongoose init.

[iamdanthedev]

The problem is that typegoose has mongoose (and typescript) defined as dependencies in package.json. And versions are set strict. That's why typegoose actually brings his own mongoose and typescript inside node_modules/typegoose/node_modules , and uses not that mongoose which we require and install separately

This deps should be peerDependencies or maybe the version should not be set strict

:-(

[Christilut]

Just noticed that my pre-save stopped working after the above workaround

@pre<User>('save', async function (next) {
  console.log('pre save !!!') 

  next()
})

export class User extends Typegoose {
}

export const UserModel = new User().getModelForClass(User)

This is pretty much the example code (and it did work earlier).

[Christilut]

My pre-save suddenly started working again, this is what happenend:

In my model I had the created property, which is to be set in the pre-save

  @prop({
    required: true
  })
  created: Date

Pre-save:

  if (this.isNew) {
    this.created = new Date()
  }

But that triggered a validation error that created was required. So apparently validation is triggered before the pre-save and properties that get set in the pre-save shouldn't have required on them.

[neckaros]

very hard to find issue indeed! my await was just never returning and nerver throwing!

[hasezoey]

this can be closed, because mongoose 5.0+ uses the default Promise, and typegoose uses an "up-to-date" mongoose version

@Ben305