Three.js dependency is removed from package.json about giojs

[syt123450]

It may be because we have not add three as dependency in package.json, we may try it in ten hours, I hope it can work.

[zchholmes]

@BoTime, do you mean after you run the command "npm install giojs --save", you can immediately receive the message, or after installing, then run some js code with the giojs, you get the warning?

[zchholmes]

@syt123450 For sure, it's from the package.json. Now in the package.json, the dependencies is empty, like:
... "dependencies": {}, ...
I think someone modified the package.json, since when I first publish "gio.js", the "dependencies" is fine, i.e. contains "three.js".

[syt123450]

When I add three and stats dependencies to giojs, it still can not be automatically install when I install giojs @zchholmes

[zchholmes]

I just tried on my test project, there's no problem about the dependency, i.e. three and stats can be imported the same as the giojs installed.

@syt123450 Can you check the "package.json" of "giojs" in the "node_modules" directory?

[syt123450]

try it in our react-giojs folder, if we remove the "three" and "stats.js" dependencies from our package, when we run npm install, they will not be install to node_module

[zchholmes]

I think that's what suppose happened, since you removed from the package.json.

Any time you want to include and dependencies, you have to make sure you include it in the package.json "dependencies".

We should consider "giojs" and "react-giojs" as two separated npm projects, which means we need two package.json files to manage each of them.

[zchholmes]

I have no dependency issue when I npm install "giojs" or "react-giojs"

[syt123450]

Add dependencies can solve this problem.